add_query_args() mangles URLs with encoded arrays in them

[ryan]

?cats%5B%5D=3 is changed to ?cats=Array. This breaks paging links and canonical redirects for these URLs.

[markjaquith]

First try

[markjaquith]

Need to pass '&' as separator, but our PHP4 compat function doesn't respect that. I've not found a suitable replacement function. The one in PEAR is no good.

[markjaquith]

better logic

[markjaquith]

003

Upgrades our http_build_query() compat function, which has been renamed to _http_build_query() with a pass-through for compat. Because early PHP5 versions don't accept the separator param, we could get wacky results if it is set in php.ini, so unless it is '&' in php.ini, we use our own version.

I haven't thoroughly tested this... but just wanted to throw it out there before I retired for the night.

[markjaquith]

(In [5999]) Preserve query string arrays in add_query_arg(). fixes #4878 for trunk

[markjaquith]

This broke some things in the admin where an & delimited query string was being passed to add_query_arg()

Proposed solution is converting & to & in add_query_arg()

We should be deprecating the passing of & to these functions.

[markjaquith]

(In [6005]) Turn & to & in add_query_arg(). fixes #4878

[markjaquith]

(In [6064]) Only urlencode previously existing values in add_query_arg() (more backwards compatible). fixes #4935. see #4084. see #4878

[markjaquith]

(In [6069]) Forgot to use $lsb and $rsb in [6064]. Props mdawaffe. see #4935. see #4878

[markjaquith]

(In [6070]) Actually, we always need to URLencode square brackets... or wp_redirect() will strip them out. see #4935. see #4878