WordPress.org

Make WordPress Core

Opened 18 months ago

Closed 3 months ago

Last modified 3 months ago

#48782 closed defect (bug) (fixed)

Fix link-manager styles

Reported by: antonlukin Owned by: SergeyBiryukov
Milestone: 5.7 Priority: normal
Severity: minor Version: 5.3
Component: Posts, Post Types Keywords: has-screenshots good-first-bug has-patch commit
Focuses: ui, css Cc:

Description

Link Manager lacks the required form styles. Need to add some padding to .inside element.

Attachments (5)

link-manager.png (158.1 KB) - added by antonlukin 18 months ago.
Link-manager styles bug
48782-patch-applied.png (14.7 KB) - added by pbiron 6 months ago.
with the PR applied
48782.diff (2.9 KB) - added by sabernhardt 3 months ago.
including the 4 previously suggested revisions to edit.css
Capture d’écran 2021-02-16 à 18.37.18.png (102.0 KB) - added by audrasjb 3 months ago.
before patch
Capture d’écran 2021-02-16 à 18.39.01.png (164.7 KB) - added by audrasjb 3 months ago.
after patch

Download all attachments as: .zip

Change History (23)

@antonlukin
18 months ago

Link-manager styles bug

#1 @SergeyBiryukov
18 months ago

Hi there, welcome to WordPress Trac! Thanks for the ticket.

For some context, Link Manager is deprecated in core since WordPress 3.5:

  • #21307 hides it in the UI for newer installs and requires the Link Manager plugin to re-enable.
  • #22994 removes it from import options.
  • #42131 proposes to remove it completely, though closed as maybelater for now.

That said, I have no objections to fixing the padding if it doesn't require too much effort.

This ticket was mentioned in Slack in #core-css by ryelle. View the logs.


8 months ago

This ticket was mentioned in Slack in #core-css by kirstyburgoine. View the logs.


8 months ago

#4 @kburgoine
8 months ago

  • Keywords needs-patch good-first-bug added
  • Milestone changed from Awaiting Review to Future Release

This ticket was mentioned in PR #753 on WordPress/wordpress-develop by grzim.


6 months ago

  • Keywords has-patch added; needs-patch removed

add margins to inputs as described in 48782.
add a border-bottom to headers to make all headers consistent.

In order to access Links, please download the plugin from https://wordpress.org/plugins/link-manager/ and upload it from your computer.

Trac ticket: https://core.trac.wordpress.org/ticket/48782

#6 @prbot
6 months ago

github-actions[bot] commented on PR #753:

Hi @grzim! 👋

Thank you for your contribution to WordPress! 💖

It looks like this is your first pull request to wordpress-develop. Here are a few things to be aware of that may help you out!

No one monitors this repository for new pull requests. Pull requests must be attached to a Trac ticket to be considered for inclusion in WordPress Core. To attach a pull request to a Trac ticket, please include the ticket's full URL in your pull request description.

Pull requests are never merged on GitHub. The WordPress codebase continues to be managed through the SVN repository that this GitHub repository mirrors. Please feel free to open pull requests to work on any contribution you are making.

More information about how GitHub pull requests can be used to contribute to WordPress can be found in this blog post.

Please include automated tests. Including tests in your pull request is one way to help your patch be considered faster. To learn about WordPress' test suites, visit the Automated Testing page in the handbook.

If you have not had a chance, please review the Contribute with Code page in the WordPress Core Handbook.

The Developer Hub also documents the various coding standards that are followed:

Thank you,
The WordPress Project

This ticket was mentioned in Slack in #meta by timothybjacobs. View the logs.


6 months ago

@pbiron
6 months ago

with the PR applied

#9 @pbiron
6 months ago

I still have a few sites that use Link Manager and the PR LGTM, so I'd so this should be fixed.

Version 0, edited 6 months ago by pbiron (next)

#10 @sabernhardt
6 months ago

  • Milestone changed from Future Release to 5.7

Thanks for the PR @grzim! The styles look good on the Add New Link page, but the .inside top margin is still only 6 pixels on the Edit Link page instead of 12.

Here are a few suggestions:

  1. Include .link-php #poststuff .inside for the override (or else add a new class to the first div within the form element on both pages).
  2. Move this style override after #poststuff .inside.
  3. Only specify the top margin for the .link-php and .link-add-php styles.
  4. Simplify the existing shorthand for #poststuff .inside.
#poststuff .inside {
	margin: 6px 0 0;
}

.link-php #poststuff .inside,
.link-add-php #poststuff .inside {
	margin-top: 12px;
}

#11 @SergeyBiryukov
4 months ago

  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

This ticket was mentioned in Slack in #core by sergey. View the logs.


4 months ago

#13 @prbot
3 months ago

draganescu commented on PR #753:

Howdy @grzim is this comment something you're looked at in this PR?

@sabernhardt
3 months ago

including the 4 previously suggested revisions to edit.css

#14 @sabernhardt
3 months ago

Refreshed patch in 48782.diff to see if this still can be committed for the 5.7 release

#15 @audrasjb
3 months ago

  • Keywords commit added

48782.diff looks good to me (see screenshots above). Marking this for commit.

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


3 months ago

#17 @johnbillion
3 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 50357:

Posts, Post Types: Update the styling of the legacy Links editing screen.

This brings its styling inline with other meta boxes in the admin area.

Props antonlukin, kburgoine, grzim, sabernhardt, pbiron, audrasjb

Fixes #48782

#18 @prbot
3 months ago

grzim commented on PR #753:

I think we can close this issue as https://core.trac.wordpress.org/ticket/48782 has been closed

Note: See TracTickets for help on using tickets.