Opened 6 years ago
Closed 6 years ago
#48799 closed defect (bug) (fixed)
"At a Glance" comment count font size is larger than other counts
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 5.4 | Priority: | normal |
| Severity: | normal | Version: | |
| Component: | Administration | Keywords: | good-first-bug has-patch needs-testing |
| Focuses: | ui, css | Cc: |
Description
In the WordPress dashboard, on a mobile browser, the font size applied to "At a Glance" items is 13px. This rule is applied via .postbox .inside in common.css.
The .post-count, .page-count, and .comment-mod-count elements all inherit this value.
The .comment-count element differs in that a font-size: 14px; from list-tables.css overrides the postbox value.
.comment-count itself is confusing because I'm pretty sure its only other use is in the post list table when a post has 0 approved comments and 1 or more pending comments. Even then, the 14px style only applies on mobile and in the mobile view that comment count is hidden.
I'm fairly certain that the .comment-count rule in list-tables.css could be removed without consequence, but I'll leave that up to those more familiar. :)
I originally noticed this in Google Chrome on a Pixel 3 and reproduced it in Firefox on a laptop at a 411x731 screen size.
Attachments (3)
Change History (11)
#2
@
6 years ago
- Keywords good-first-bug added
- Milestone changed from Awaiting Review to Future Release
This ticket was mentioned in Slack in #core by sergey. View the logs.
6 years ago
#6
@
6 years ago
- Milestone changed from Future Release to 5.4
- Owner set to SergeyBiryukov
- Status changed from new to reviewing
Introduced in [26134].
#7
in reply to:
↑ description
@
6 years ago
Replying to jeremyfelt:
.comment-countitself is confusing because I'm pretty sure its only other use is in the post list table when a post has 0 approved comments and 1 or more pending comments. Even then, the 14px style only applies on mobile and in the mobile view that comment count is hidden.
Right. Not only it's hidden, but the font size is also overridden by a more specific selector, so the style in question has no effect and can be safely removed. 48799.diff should be good to go.
I think you're right @jeremyfelt. I did some scanning and search in the core code and I don't see any usage of the class
.comment-countexcept for theAt a Glanceand in the bubble inedit-comments.phpbut indeed, it is hidden when the.comment-countstyle fromlist-tables.cssis applied.