WordPress.org

Make WordPress Core

Opened 9 months ago

Closed 3 months ago

#48803 closed defect (bug) (fixed)

Twenty Twenty: Custom post type that doesn't support author, shows author

Reported by: ianbelanger Owned by: ianbelanger
Milestone: 5.4.2 Priority: normal
Severity: normal Version: 5.3
Component: Bundled Theme Keywords: has-patch commit fixed-major
Focuses: Cc:

Description

Originally reported on GitHub by @joyously

https://github.com/WordPress/twentytwenty/issues/954

Steps to reproduce

  • Create a custom post type and specify that it does not support author (similar to Page).
  • Create a new post of that post type.
  • View that post on the front end.
  • The author is shown under the title, even though the post type does not support author.

Attachments (2)

48803.diff (672 bytes) - added by donmhico 8 months ago.
48803.1.diff (1.8 KB) - added by ianbelanger 8 months ago.
refresh patch including author bio removal

Download all attachments as: .zip

Change History (9)

@donmhico
8 months ago

#1 @donmhico
8 months ago

  • Keywords has-patch added; needs-patch removed

@ianbelanger - The patch, https://core.trac.wordpress.org/attachment/ticket/48803/48803.diff, should fix the issue.

#2 @ianbelanger
8 months ago

  • Keywords needs-refresh added; needs-testing removed

The patch does fix the issue, however while testing I found that the author bio box also shows on CPT's that don't support authors. I think that we should probably fix this issue as well.

@ianbelanger
8 months ago

refresh patch including author bio removal

#3 @ianbelanger
8 months ago

  • Keywords needs-testing added; needs-refresh removed

#4 @ianbelanger
3 months ago

  • Keywords commit added; needs-testing removed
  • Owner set to ianbelanger
  • Status changed from new to assigned

#5 @ianbelanger
3 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 47799:

Bundled Themes: Twenty Twenty custom post types that don't support authors, shows author box.

This fixes the issue where custom post types will show an author box, even if they don't support authors.

Props joyously, donmhico.
Fixes #48803.

#6 @ianbelanger
3 months ago

  • Keywords fixed-major added
  • Milestone changed from Future Release to 5.4.2
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backport.

#7 @whyisjake
3 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 47830:

Bundled Themes: Twenty Twenty custom post types that don't support authors, shows author box.
This fixes the issue where custom post types will show an author box, even if they don't support authors.

This brings the changes in [47799] to the 5.4 branch.

Props joyously, donmhico.
Fixes #48803.

Note: See TracTickets for help on using tickets.