WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#48841 closed defect (bug) (fixed)

Add missing doc and refactor code for REST API: WP_REST_Attachments_Controller Class

Reported by: dkarfa's profile dkarfa Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.4 Priority: normal
Severity: normal Version:
Component: REST API Keywords: has-patch
Focuses: rest-api Cc:

Description


Attachments (2)

48841.patch​ (3.1 KB) - added by dkarfa 5 years ago.
48841.1.patch​ (3.1 KB) - added by dkarfa 5 years ago.

Download all attachments as: .zip

Change History (8)

@dkarfa
5 years ago

#1 @SergeyBiryukov
5 years ago

  • Milestone changed from Awaiting Review to 5.4
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#2 @mukesh27
5 years ago

@dkarfa One small text change suggestion.

Registers routes for attachments.

Replace to

Register routes for the attachments.

@dkarfa
5 years ago

#3 @dkarfa
5 years ago

Hi @mukesh27,
I have updated the patch.
Thank you,

This ticket was mentioned in ​Slack in #core-restapi by timothybjacobs. ​View the logs.
5 years ago

This ticket was mentioned in ​Slack in #core by david.baumwald. ​View the logs.
5 years ago

#6 @SergeyBiryukov
5 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 47391:

Docs: Improve documentation for WP_REST_Attachments_Controller.

This adds a missing DocBlock for ::register_routes() and parameter descriptions for ::post_process_item().

Includes minor documenation fixes in other REST API classes for consistency.

Props dkarfa, mukesh27, SergeyBiryukov.
Fixes #48841.

Note: See TracTickets for help on using tickets.