Unit test for wp()

[pbearne]

Just a simple test for the wp() function in functions.php

It not posable to test fully as the WP object has already been created by the test framework

[donmhico]

Full test suite failure

[donmhico]

Thanks for the patch @pbearne. The test works fine when run separately phpunit --group=48844 after I added @ticket on it. But it fails on a full test suite.

I'm suspecting that somewhere in the test suite either or both $wp_query and $wp_the_query was changed. Need some more digging.

[pbearne]

I will have to dig as the tests should not be changing $wp_query and $wp_the_query we may have found a bug in the tests :-)

[SergeyBiryukov]

The last assertion fails because:

1. wp() only sets $wp_the_query if it's not already set​.
2. It is actually already set earlier in wp-settings.php​.
3. It is then reset in WP_UnitTestCase_Base::go_to()​, called by various canonical tests.
4. After that, the variable no longer points to the same object, so assertSame() fails.

Some history on that code:

• [4460] introduced setting $wp_the_query in wp-settings.php.
• [6233] introduced setting $wp_the_query in wp(). However, the commit message on that changeset was wrong, see [6232] / #5121 for the correct commit message.

Note that WP::main() calls WP::query_posts(), which produces a fatal error if $wp_the_query is not set by then (Call to a member function query() on null), and did so in WP 2.3.3 too.

Given that, I'm not sure if [6232] actually fixed anything, setting $wp_the_query in wp() seems redundant. As far as I can tell, that line is never reached, but confirming that would require some more testing.

For now, let's get the unit test in, except for the last assertion, which apparently cannot be reliably tested.

[SergeyBiryukov]

In 47212:

Tests: Add a basic test for wp() function.

Props pbearne, donmhico.
Fixes #48844.