Changes between Initial Version and Version 1 of Ticket #48850, comment 57
- Timestamp:
- 02/04/2020 04:18:10 PM (5 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #48850, comment 57
initial v1 13 13 I can confirm it's ok from an accessibility point of view, and the design team already discussed the current patch during meetings. But I know they are not totally comfortable with the current proposal so alternatives are very welcome. In any case, the ticket is open since weeks, so other design should be proposed as soon a possible to help this moving forward. 14 14 15 Basically, I don't think it's realistic to add a completely new UI control. 16 15 17 16 18 > > also, deep code review and testing is more than welcome … … 18 20 > When everything is undecided and in-flux, code review seems premature. Personally, I'm always happy to help (and only trying to be helpful) but I have a hard time reviewing some parts (code) and not others (design) because it's all equally important, and they both rely on each other. 19 21 20 I personally think we need to need a solid code basis first, but Iadmit it's very personal as well :)22 I personally think we need a solid code basis first, but I have to admit it's very personal as well :) 21 23 22 24