![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 7 years ago
Closed 2 years ago
#48861 closed defect (bug) (wontfix)
Twenty Seventeen inserts an empty .entry-footer content for custom post type posts with no taxonomy
| Reported by: | umchal | Owned by: | |
|---|---|---|---|
| Priority: | normal | Milestone: | |
| Component: | Bundled Theme | Version: | |
| Severity: | normal | Keywords: | needs-testing dev-feedback 2nd-opinion close |
| Cc: | Focuses: |
Description
Hi there,
Just reporting that the Twenty Seventeen theme v2.2 checks whether the entry footer is empty in order to avoid a huge blank space.
/inc/template-tags.php
<?php // We don't want to output .entry-footer if it will be empty, so make sure its not. if ( ( ( twentyseventeen_categorized_blog() && $categories_list ) || $tags_list ) || get_edit_post_link() ) {
However, this check fails for cases of posts of a custom post type with no taxonomy terms associated and a big empty space gets inserted at the bottom of the singular page.
$categories_list is not empty as the string value Uncategorized is assigned by get_the_category_list() (/wp-includes/category-template.php)
Change History (5)
Note:
See TracTickets
for help on using tickets.
I am cautious about changing this now and the impact so let's get some feedback and thoughts by adding a keyword for that.