Twenty Seventeen inserts an empty .entry-footer content for custom post type posts with no taxonomy

[umchal]

Hi there,

Just reporting that the Twenty Seventeen theme v2.2 checks whether the entry footer is empty in order to avoid a huge blank space.

/inc/template-tags.php

<?php
                // We don't want to output .entry-footer if it will be empty, so make sure its not.
                if ( ( ( twentyseventeen_categorized_blog() && $categories_list ) || $tags_list ) || get_edit_post_link() ) {

                

However, this check fails for cases of posts of a custom post type with no taxonomy terms associated and a big empty space gets inserted at the bottom of the singular page.

$categories_list is not empty as the string value Uncategorized is assigned by get_the_category_list() (/wp-includes/category-template.php)

[karmatosed]

I am cautious about changing this now and the impact so let's get some feedback and thoughts by adding a keyword for that.

[karmatosed]

For now, I am going to add the close keyword as a candidate for this. We can consider if other opinions come up though. Thank you everyone for your collaboration.

[karmatosed]

I am going to follow through with close on this, thank you everyone.