Make WordPress Core

Opened 4 years ago

Last modified 10 days ago

#48861 new defect (bug)

Twenty Seventeen inserts an empty .entry-footer content for custom post type posts with no taxonomy

Reported by: umchal's profile umchal Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Bundled Theme Keywords: needs-testing dev-feedback 2nd-opinion
Focuses: Cc:

Description

Hi there,

Just reporting that the Twenty Seventeen theme v2.2 checks whether the entry footer is empty in order to avoid a huge blank space.

/inc/template-tags.php

<?php
                // We don't want to output .entry-footer if it will be empty, so make sure its not.
                if ( ( ( twentyseventeen_categorized_blog() && $categories_list ) || $tags_list ) || get_edit_post_link() ) {

                

However, this check fails for cases of posts of a custom post type with no taxonomy terms associated and a big empty space gets inserted at the bottom of the singular page.

$categories_list is not empty as the string value Uncategorized is assigned by get_the_category_list() (/wp-includes/category-template.php)

Change History (3)

#1 @mukesh27
4 years ago

  • Component changed from Themes to Bundled Theme

#2 @karmatosed
7 weeks ago

  • Keywords needs-testing added

#3 @karmatosed
10 days ago

  • Keywords dev-feedback 2nd-opinion added

I am cautious about changing this now and the impact so let's get some feedback and thoughts by adding a keyword for that.

Note: See TracTickets for help on using tickets.