WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 6 years ago

#48863 closed defect (bug) (fixed)

i18n: Use %s placeholders in wp-admin/options-permalink.php

Reported by: ramiy's profile ramiy Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.4 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-screenshots has-patch
Focuses: administration Cc:

Description

Found 3 translation strings in wp-admin/options-permalink.php file that display the file name inside the string, instead of using %s placeholders.

I also checked all other strings in this file, those are the only strings that don't use placeholders.

Attachments (2)

48863.png​ (35.9 KB) - added by ramiy 6 years ago.
48863.patch​ (1.2 KB) - added by ramiy 6 years ago.

Download all attachments as: .zip

Change History (8)

@ramiy
6 years ago

@ramiy
6 years ago

#1 @ramiy
6 years ago

  • Keywords has-screenshots has-patch added

#2 @SergeyBiryukov
6 years ago

  • Milestone changed from Awaiting Review to 5.4

#3 @SergeyBiryukov
6 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 46957:

I18N: Replace file names in translatable strings on Permalink Settings screen with placeholders.

Props ramiy.
Fixes #48863.

#4 follow-up: @apedog
6 years ago

  • Resolution fixed deleted
  • Status changed from closed to reopened

@ramiy

On first string:

להוריד = download
להסיר = remove

Also, original text is an imperative, a command - Remove X now!
Translation string is optional - You may now remove X.

#5 in reply to: ↑ 4 @ramiy
6 years ago

Replying to apedog:

@ramiy

On first string:

להוריד = download
להסיר = remove

Also, original text is an imperative, a command - Remove X now!
Translation string is optional - You may now remove X.

Fixed.

Thank you for the feedback!

#6 @SergeyBiryukov
6 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed
Note: See TracTickets for help on using tickets.