i18n: WordPress update string

[ramiy]

If you check the ​Success strings and the ​Fail strings, you will see we don't use the "SUCCESS:" and the "FAILED:" prefix.

This patch removes the prefixes and uses the

[SergeyBiryukov]

Thanks for the ticket!

As seen in class-wp-automatic-updater.php​, here's the list of the affected strings:

• SUCCESS: WordPress was successfully updated to %s
• FAILED: WordPress failed to update to %s
• These strings are also displayed with the SUCCESS: prefix:
  • The following plugins were successfully updated:
  • The following themes were successfully updated:
  • The following translations were successfully updated:
• These strings are also displayed with the FAILED: prefix:
  • The following plugins failed to update:
  • The following themes failed to update:
  • The following translations failed to update:

While we don't generally include the SUCCESS: or FAILED: prefix in strings displayed in the UI, I think these strings from WP_Automatic_Updater::send_debug_email() are different in that they're used in debugging emails for easier scanning, to take a quick look (or maybe set up alert notifications) if there are any failures.

I don't see any benefit in removing these prefixes. We could probably remove the prefix from the first two strings and re-add it with sprintf(), same as for plugin and theme notifications​, but I don't see what problem would that solve either.

[hellofromTonya]

Hello @ramiy,

Welcome to WordPress Core's Trac. Thank you for the ticket and suggestion.

These strings are for debugging and geekery, i.e. WP_Automatic_Updater::send_debug_email(). The design is intentional to help in the debug process.

I agree with @SergeyBiryukov's assessment.

I'll close this ticket. Please feel free to reopen to continue the discussion.