WordPress.org

Make WordPress Core

Opened 8 months ago

Last modified 7 months ago

#48871 assigned defect (bug)

i18n: WordPress update string

Reported by: ramiy Owned by: SergeyBiryukov
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-screenshots has-patch 2nd-opinion close
Focuses: administration Cc:

Description

If you check the Success strings and the Fail strings, you will see we don't use the "SUCCESS:" and the "FAILED:" prefix.

This patch removes the prefixes and uses the

Attachments (4)

48871a.png (5.9 KB) - added by ramiy 8 months ago.
48871b.png (8.5 KB) - added by ramiy 8 months ago.
48871c.png (7.2 KB) - added by ramiy 8 months ago.
48871.patch (912 bytes) - added by ramiy 8 months ago.

Download all attachments as: .zip

Change History (8)

@ramiy
8 months ago

@ramiy
8 months ago

@ramiy
8 months ago

@ramiy
8 months ago

#1 @ramiy
8 months ago

  • Focuses administration added
  • Keywords has-screenshots has-patch added

#2 @ramiy
8 months ago

  • Component changed from General to I18N

This ticket was mentioned in Slack in #core-i18n by ramiy. View the logs.


7 months ago

#4 @SergeyBiryukov
7 months ago

  • Keywords 2nd-opinion close added

Thanks for the ticket!

As seen in class-wp-automatic-updater.php, here's the list of the affected strings:

  • SUCCESS: WordPress was successfully updated to %s
  • FAILED: WordPress failed to update to %s
  • These strings are also displayed with the SUCCESS: prefix:
    • The following plugins were successfully updated:
    • The following themes were successfully updated:
    • The following translations were successfully updated:
  • These strings are also displayed with the FAILED: prefix:
    • The following plugins failed to update:
    • The following themes failed to update:
    • The following translations failed to update:

While we don't generally include the SUCCESS: or FAILED: prefix in strings displayed in the UI, I think these strings from WP_Automatic_Updater::send_debug_email() are different in that they're used in debugging emails for easier scanning, to take a quick look (or maybe set up alert notifications) if there are any failures.

I don't see any benefit in removing these prefixes. We could probably remove the prefix from the first two strings and re-add it with sprintf(), same as for plugin and theme notifications, but I don't see what problem would that solve either.

Note: See TracTickets for help on using tickets.