Make WordPress Core

Opened 4 months ago

Last modified 4 months ago

#48874 assigned defect (bug)

i18n: Use %s placeholders in wp-admin/edit-form-advanced.php

Reported by: ramiy Owned by: SergeyBiryukov
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-screenshots has-patch
Focuses: administration Cc:


This patch replaces <kbd>Alt + F10</kbd> with %s in the translation string.

Why? translators can mistakenly use wrong keyboard keys when translating the string. With %s placeholder we hardcode the keys, making sure there will be no mistakes.

Attachments (2)

48874.png (18.4 KB) - added by ramiy 4 months ago.
48874.patch (1.6 KB) - added by ramiy 4 months ago.

Download all attachments as: .zip

Change History (5)

4 months ago

4 months ago

#1 @ramiy
4 months ago

  • Keywords has-screenshots has-patch added

#2 @tobifjellner
4 months ago

Are these keys always labelled ALT and F10 for all languages and scripts? (When I looked at Japanese, Korean and Arabic, they all seem to keep it this way, at least.)

Would RTL present these keys in the logical order if we do this change?

#3 @ramiy
4 months ago

@tobifjellner Thank you for your feedback.

This ticket don't change the logical order of the keys. The ticket only hard-code the keys, taking them out of the translation string.

Note: See TracTickets for help on using tickets.