WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#48883 closed defect (bug) (fixed)

i18n: unify similar translation strings for edited items

Reported by: ramiy Owned by: SergeyBiryukov
Milestone: 5.4 Priority: normal
Severity: normal Version:
Component: I18N Keywords: has-screenshots has-patch
Focuses: administration Cc:

Description

Some translation strings have the same meaning but different wording. This ticket unifies the language being used in error messages for items that could not be edited.

Attachments (2)

48883.png (65.5 KB) - added by ramiy 2 years ago.
48883.patch (1.6 KB) - added by ramiy 2 years ago.

Download all attachments as: .zip

Change History (7)

@ramiy
2 years ago

@ramiy
2 years ago

#1 @ramiy
2 years ago

  • Keywords has-screenshots has-patch added

The new format is: Sorry, this XXX could not be edited.

#2 @SergeyBiryukov
2 years ago

  • Milestone changed from Awaiting Review to 5.4

#3 follow-up: @SergeyBiryukov
2 years ago

Thanks for the patch! Some notes:

  • 'Sorry, X could not be edited' implies some kind of error: invalid ID, failed request, etc.
  • 'Sorry, X cannot be edited' implies a more permanent state, which is the case for deprecated blogger_getTemplate() and blogger_setTemplate() methods, see [22914].

With that in mind, I'd suggest replacing those two strings with Sorry, this method is not supported.

The rest of the changes look good, though need some further adjustments for consistency.

#4 @SergeyBiryukov
2 years ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 46814:

XML-RPC: Unify some "could not be created/updated/deleted" error messages for consistency.

Props ramiy, SergeyBiryukov.
Fixes #48883.

#5 in reply to: ↑ 3 @ramiy
2 years ago

Replying to SergeyBiryukov:

Thanks for the patch! Some notes:

  • 'Sorry, X could not be edited' implies some kind of error: invalid ID, failed request, etc.
  • 'Sorry, X cannot be edited' implies a more permanent state, which is the case for deprecated blogger_getTemplate() and blogger_setTemplate() methods, see [22914].

With that in mind, I'd suggest replacing those two strings with Sorry, this method is not supported.

The rest of the changes look good, though need some further adjustments for consistency.

Even better! Thank you for the in depth review.

Note: See TracTickets for help on using tickets.