WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#48907 closed enhancement (fixed)

Media Editor: Consistent width for Scale and Crop inputs

Reported by: sabernhardt's profile sabernhardt Owned by: audrasjb's profile audrasjb
Milestone: 5.3.1 Priority: normal
Severity: minor Version:
Component: Media Keywords: has-patch commit has-screenshots
Focuses: ui, accessibility, css Cc:

Description (last modified by SergeyBiryukov)

For version 5.3, the width for Scale Image and Image Crop inputs was increased from 50 to 80 pixels on larger screens (ticket #47115, commit [46359]). However, I missed how the stylesheet resets that width to 60px for smaller screens (up to 782px viewport width).

The current 60 pixels may be enough for most people, but there is plenty of space available to make them consistent at 80px.

Attachments (3)

inputs-60px.png​ (7.1 KB) - added by sabernhardt 5 years ago.
current inputs at 60 pixels wide
inputs-80px.png​ (15.3 KB) - added by sabernhardt 5 years ago.
with a significant increase in text size, 4 digits are visible in 80px-wide inputs
48907.diff​ (459 bytes) - added by sabernhardt 5 years ago.
patch removes width adjustment (instead of setting the same value again)

Download all attachments as: .zip

Change History (8)

@sabernhardt
5 years ago

current inputs at 60 pixels wide

@sabernhardt
5 years ago

with a significant increase in text size, 4 digits are visible in 80px-wide inputs

@sabernhardt
5 years ago

patch removes width adjustment (instead of setting the same value again)

#1 @SergeyBiryukov
5 years ago

  • Description modified (diff)
  • Milestone changed from Awaiting Review to 5.3.1

#2 @audrasjb
5 years ago

  • Keywords has-patch commit has-screenshots added
  • Owner set to audrasjb
  • Status changed from new to accepted

Hi,

Thanks for spotting this, @sabernhardt.
I tested the patch and it looks good to me.
Adding commit keyword.

#3 @SergeyBiryukov
5 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 46856:

Media: Use consistent width for Scale and Crop inputs.

Follow-up to [46359].

Props sabernhardt, audrasjb.
Fixes #48907.

#4 @SergeyBiryukov
5 years ago

In 46857:

Media: Use consistent width for Scale and Crop inputs.

Follow-up to [46359].

Props sabernhardt, audrasjb.
Merges [46856] to the 5.3 branch.
Fixes #48907.

This ticket was mentioned in ​Slack in #core-site-health by afragen. ​View the logs.
5 years ago

Note: See TracTickets for help on using tickets.