Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #48916, comment 11


Ignore:
Timestamp:
05/09/2020 03:45:34 AM (4 years ago)
Author:
Giorgio25b
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #48916, comment 11

    initial v1  
    1 Replying to [comment:10 ianbelanger]:
    2 > Thanks for all of your work on this @Giorgio25b, @bdcstr, @samful, @yuhin and @suzylah. I have just uploaded an updated patch that includes a check to see if the modal is active. After applying @Giorgio25b patch clicking on an anchor link that was not in the modal would throw an error in the console.
    3 >
    4 > `Uncaught TypeError: Cannot read property 'dataset' of null`
    5 >
    6 > My patch fixes this by adding a check to make sure that `modal` is not `null`.
    7 >
    8 > Testing on multiple different devices would be appreciated.
    9 
    101Hi @ianbelanger , thanks for the attention to details!
    112I've pushed a comprehensive PR with a fully tested patch (local, live, mobile, tablet, win/mac, etc).