WordPress.org

Make WordPress Core

Opened 17 months ago

Last modified 3 weeks ago

#48929 new defect (bug)

Recovery mode page references checking your site admin email, even in Multisite

Reported by: rkaiser0324 Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 5.3
Component: Site Health Keywords: needs-copy-review
Focuses: multisite, ui-copy Cc:

Description

In display_default_error_template() the message references checking your email if the endpoint is protected. However, in WP_Fatal_Error_Handler::handle() it will never call handle_error() if is_multisite() is true.

So the error message is misleading in that case, so no email was actually sent.

The error message shouldn't reference checking your email if no email sending was attempted.

Attachments (1)

48929.patch (1.3 KB) - added by Clorith 3 weeks ago.

Download all attachments as: .zip

Change History (3)

#1 @SergeyBiryukov
17 months ago

  • Component changed from General to Site Health

@Clorith
3 weeks ago

#2 @Clorith
3 weeks ago

  • Keywords needs-copy-review added

Thank you very much for your report of this @rkaiser0324, you are quite right that this is text was misleading.

48929.patch is a suggested resolution, where the text is more aware of the current site setup, providing different texts if it is a protected endpoint, but you are, or are not, on a multisite install.

Standalone site:

There has been a critical error on this website. Please check your site admin email inbox for instructions.

Multisite:

There has been a critical error on this website. Please reach out to your site administrator, and inform them of this error for further assistance.

I opted for the term site administrator over network administrator, as the last one also has meanings for businesses where this is also used as the term for whomever handles networking issues in the office or similar.

Note: See TracTickets for help on using tickets.