#4893 closed enhancement (invalid)
Audit of all filter and action names.
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | Priority: | normal | |
| Severity: | normal | Version: | |
| Component: | Plugins | Keywords: | |
| Focuses: | Cc: |
Description
I think for 2.4 we should do an early audit of all the filters and actions in the core and ensure that they follow the following set of rules:
- All names should be unique
- All names should be relevant to the calling context
- All filters should pass in relevant context information
This should then ensure plugins can easily filter just the things they want to.
This is to avoid messes like the_title
./wp-includes/post-template.php: return apply_filters( 'the_title', $title );
./wp-includes/comment.php: $post_title = apply_filters('the_title', $post->post_title);
./wp-includes/classes.php: $output .= $indent . '<li class="' . $css_class . '"><a href="' . get_page_link($page->ID) . '" title="' . att
ribute_escape(apply_filters('the_title', $page->post_title)) . '">' . apply_filters('the_title', $page->post_title) . '</a>';
./wp-includes/deprecated.php: $string .= apply_filters('the_title', $post->post_title, $post);
./wp-includes/deprecated.php: $string .= apply_filters('the_title', $post->post_title, $nextpost);
./wp-includes/link-template.php: $title = apply_filters('the_title', $post->post_title, $post);
./wp-includes/link-template.php: $title = apply_filters('the_title', $post->post_title, $post);
./wp-includes/general-template.php: $text = strip_tags(apply_filters('the_title', $arc_title));
Change History (15)
#7
@
17 years ago
- Component changed from General to Plugins
shouldn't we close this? as in, it's too late?
#13
@
12 years ago
- Milestone Future Release deleted
- Resolution set to invalid
- Status changed from new to closed
This has sailed a dozen times around the world by now. Closing. New tickets for specific issues.
This ticket was mentioned in IRC in #wordpress-dev by nacin. View the logs.
12 years ago
Note: See
TracTickets for help on using
tickets.
I think 'the_title' filters should probably be moved to 'post_title' so we can let sanitize_post apply the filters. All of the places manually applying the_title would then use sanitize_post.