#48933 closed defect (bug) (fixed)
Incorrect configuration value name in unit tests
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.4 | Priority: | low |
Severity: | minor | Version: | |
Component: | Build/Test Tools | Keywords: | |
Focuses: | Cc: |
Description
The default test configuration in phpunit.xml.dist
has threshold entry for slow tests that is incorrectly named.
The current config says <element key="slow_threshold">
and the name expected by code is slowThreshold
.
While the code defaults to same 500
ms value anyway, this is very confusing when config is edited or followed as an example and the new value doesn't apply.
Change History (3)
Note: See
TracTickets for help on using
tickets.
Good catch! This was committed as
slowThreshold
in [35214], then switched toslow_threshold
in [45607] per the coding standards.Either the option name change should be reverted (I think the coding standards only apply to the variable name), or the option handling in
SpeedTrapListener::loadOptions()
should be changed too.