Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 6 years ago

#48945 closed task (blessed) (fixed)

Re-add Maintenance and Security Releases changelog to the About page

Reported by: SergeyBiryukov Owned by: SergeyBiryukov
Priority: normal Milestone: 5.3.1
Component: Help/About Version:
Severity: normal Keywords: has-screenshots has-patch
Cc: Focuses: ui, administration

Description

Background: #47708

With the overhauled About page design in 5.3, we need to make sure there is a place and appropriate design for the Maintenance and Security Releases changelog, same as in previous minor releases.

See the screenshot of the changelog in 5.2.4 for reference.

Attachments (7)

48945.PNG​ (42.8 KB ) - added by SergeyBiryukov 7 years ago.
screencapture-localhost-8888-testing-features-test10-wp-admin-about-php-2019-12-12-01_31_33.png​ (290.9 KB ) - added by audrasjb 7 years ago.
Proposal
48945.diff​ (1.7 KB ) - added by audrasjb 7 years ago.
Proposal for about page changelog block in 5.3.x
Capture d’écran 2019-12-12 à 01.46.52.png​ (103.1 KB ) - added by audrasjb 7 years ago.
After 48945.diff
48945.2.diff​ (2.1 KB ) - added by SergeyBiryukov 7 years ago.
48945.2.PNG​ (55.0 KB ) - added by SergeyBiryukov 7 years ago.
48945.3.diff​ (1.7 KB ) - added by SergeyBiryukov 7 years ago.

Download all attachments as: .zip

Change History (19)

@SergeyBiryukov
7 years ago

#1 @audrasjb
7 years ago

  • Keywords needs-patch has-screenshots needs-design-feedback added

@audrasjb
7 years ago

Proposal for about page changelog block in 5.3.x

#2 @audrasjb
7 years ago

  • Keywords has-patch added; needs-patch removed

This ticket was mentioned in ​Slack in #design by audrasjb. ​View the logs.


7 years ago

#4 follow-up: @SergeyBiryukov
7 years ago

@audrasjb Ah, I got a similar result with 48945.2.diff​ / 48945.2.PNG​ :)

It also includes a padding for the section, which appears to be missing in 48945.diff​.

#5 @melchoyce
7 years ago

Approach looks good to me 👍

#6 in reply to: ↑ 4 ; follow-up: @audrasjb
7 years ago

Replying to SergeyBiryukov:

It also includes a padding for the section, which appears to be missing in 48945.diff​.

I started with a padding bottom but I replaced it with a <hr /> tag since it's the approach adopted for the other blocks :-)
Also, it avoids us to add new css rule ;)

#7 @audrasjb
7 years ago

  • Keywords needs-design-feedback removed

Thanks for your feedback Mel!

#8 in reply to: ↑ 6 @SergeyBiryukov
7 years ago

Replying to audrasjb:

I started with a padding bottom but I replaced it with a <hr /> tag since it's the approach adopted for the other blocks :-)
Also, it avoids us to add new css rule ;)

Ah, I missed that <div class="column"> already has the required padding. Should be good to go, then :)

#9 @audrasjb
7 years ago

Ah sorry I confused between padding and margin :D

But yes, indeed, I think we are good to go (and we have proper validation from the design team :)

#10 @SergeyBiryukov
7 years ago

  • Owner set to SergeyBiryukov
  • Resolution → fixed
  • Status new → closed

In 46892:

Help/About: Update the About page for 5.3.1.

Props audrasjb, melchoyce.
Fixes #48945.

#11 follow-up: @melchoyce
7 years ago

Hey, I just realized @ryelle had some docs for this: ​https://gist.github.com/ryelle/91ef6cd84a197b6af880dc055be21cc9 Does this match?

#12 in reply to: ↑ 11 @SergeyBiryukov
6 years ago

Replying to melchoyce:

Hey, I just realized @ryelle had some docs for this: ​https://gist.github.com/ryelle/91ef6cd84a197b6af880dc055be21cc9 Does this match?

Thanks for the link! Yes, this seems to match what was done in [46892] for 5.3 and [47702], [47773] for 5.4.

The only difference is that the .point-releases class is no longer used, it's only used in legacy About styles.

Note: See TracTickets for help on using tickets.