WordPress.org

Make WordPress Core

Opened 11 months ago

Closed 11 months ago

Last modified 6 months ago

#48945 closed task (blessed) (fixed)

Re-add Maintenance and Security Releases changelog to the About page

Reported by: SergeyBiryukov Owned by: SergeyBiryukov
Milestone: 5.3.1 Priority: normal
Severity: normal Version:
Component: Help/About Keywords: has-screenshots has-patch
Focuses: ui, administration Cc:

Description

Background: #47708

With the overhauled About page design in 5.3, we need to make sure there is a place and appropriate design for the Maintenance and Security Releases changelog, same as in previous minor releases.

See the screenshot of the changelog in 5.2.4 for reference.

Attachments (7)

48945.PNG (42.8 KB) - added by SergeyBiryukov 11 months ago.
screencapture-localhost-8888-testing-features-test10-wp-admin-about-php-2019-12-12-01_31_33.png (290.9 KB) - added by audrasjb 11 months ago.
Proposal
48945.diff (1.7 KB) - added by audrasjb 11 months ago.
Proposal for about page changelog block in 5.3.x
Capture d’écran 2019-12-12 à 01.46.52.png (103.1 KB) - added by audrasjb 11 months ago.
After 48945.diff
48945.2.diff (2.1 KB) - added by SergeyBiryukov 11 months ago.
48945.2.PNG (55.0 KB) - added by SergeyBiryukov 11 months ago.
48945.3.diff (1.7 KB) - added by SergeyBiryukov 11 months ago.

Download all attachments as: .zip

Change History (19)

#1 @audrasjb
11 months ago

  • Keywords needs-patch has-screenshots needs-design-feedback added

@audrasjb
11 months ago

Proposal for about page changelog block in 5.3.x

#2 @audrasjb
11 months ago

  • Keywords has-patch added; needs-patch removed

This ticket was mentioned in Slack in #design by audrasjb. View the logs.


11 months ago

#4 follow-up: @SergeyBiryukov
11 months ago

@audrasjb Ah, I got a similar result with 48945.2.diff / 48945.2.PNG :)

It also includes a padding for the section, which appears to be missing in 48945.diff.

#5 @melchoyce
11 months ago

Approach looks good to me 👍

#6 in reply to: ↑ 4 ; follow-up: @audrasjb
11 months ago

Replying to SergeyBiryukov:

It also includes a padding for the section, which appears to be missing in 48945.diff.

I started with a padding bottom but I replaced it with a <hr /> tag since it's the approach adopted for the other blocks :-)
Also, it avoids us to add new css rule ;)

#7 @audrasjb
11 months ago

  • Keywords needs-design-feedback removed

Thanks for your feedback Mel!

#8 in reply to: ↑ 6 @SergeyBiryukov
11 months ago

Replying to audrasjb:

I started with a padding bottom but I replaced it with a <hr /> tag since it's the approach adopted for the other blocks :-)
Also, it avoids us to add new css rule ;)

Ah, I missed that <div class="column"> already has the required padding. Should be good to go, then :)

#9 @audrasjb
11 months ago

Ah sorry I confused between padding and margin :D

But yes, indeed, I think we are good to go (and we have proper validation from the design team :)

#10 @SergeyBiryukov
11 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 46892:

Help/About: Update the About page for 5.3.1.

Props audrasjb, melchoyce.
Fixes #48945.

#11 follow-up: @melchoyce
11 months ago

Hey, I just realized @ryelle had some docs for this: https://gist.github.com/ryelle/91ef6cd84a197b6af880dc055be21cc9 Does this match?

#12 in reply to: ↑ 11 @SergeyBiryukov
6 months ago

Replying to melchoyce:

Hey, I just realized @ryelle had some docs for this: https://gist.github.com/ryelle/91ef6cd84a197b6af880dc055be21cc9 Does this match?

Thanks for the link! Yes, this seems to match what was done in [46892] for 5.3 and [47702], [47773] for 5.4.

The only difference is that the .point-releases class is no longer used, it's only used in legacy About styles.

Note: See TracTickets for help on using tickets.