WordPress.org

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #48965, comment 9


Ignore:
Timestamp:
04/08/2020 02:40:53 PM (22 months ago)
Author:
pikamander2
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #48965, comment 9

    initial v1  
    11@Otto42 - Yeah, that's not too surprising. My biggest fear with pushing these changes is that they might break production code.
    22
    3 On the flip side though, that's exactly why these kinds of changes are needed. Loose comparisons allow for a lot of poorly-defined behavior that's not obvious at a glance. The more comparisons we convert to strict, the easier it becomes to see what the function is expecting and can handle.
     3On the flip side though, that's exactly why these kinds of changes are needed. Loose comparisons allow for a lot of poorly-defined behavior and weird interactions. The more comparisons we convert to strict, the easier it becomes to see what the function is expecting and can handle.
    44
    55Pinging @SergeyBiryukov for thoughts.