WordPress.org

Make WordPress Core

Opened 8 months ago

Closed 5 months ago

#48970 closed defect (bug) (fixed)

Twenty Twenty : Menu rendering problem Unicode (Bangla)

Reported by: smallprogrammers Owned by: ianbelanger
Milestone: 5.4 Priority: normal
Severity: normal Version: 5.3
Component: Bundled Theme Keywords: has-patch
Focuses: css Cc:

Description

Hello i found a bug for menu rendering in Bangla language.
menu got broken and also text got broken if i write this : সাহায্য (it means "Help").

It works fine with Twenty nineteen theme.

Here is my forum post : https://wordpress.org/support/topic/unicode-rendering-problem-menu/#post-12236743

My website is : blog.aparajeyo.com

Thanks in advanced.

Attachments (5)

Capture d’écran 2019-12-16 à 09.52.02.png (43.7 KB) - added by audrasjb 8 months ago.
can't reproduce the issue on Mac OSX / Chrome
48970.diff (410 bytes) - added by Shital Patel 8 months ago.
i just removed word-break: break-word; word-wrap: break-word; in *, ::before, ::after { } style.css
Untitled.png (22.7 KB) - added by Shital Patel 8 months ago.
Before : Screenshot of windows PC firefox browser
Untitled1.png (55.3 KB) - added by Shital Patel 8 months ago.
After : Screenshot of windows PC firefox browser
48970.1.diff (1.2 KB) - added by audrasjb 7 months ago.
Reset word-break and word-wrap properties for Twenty Twenty primary and footer navigation menus

Download all attachments as: .zip

Change History (23)

#1 @SergeyBiryukov
8 months ago

  • Component changed from General to Bundled Theme

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


8 months ago

#3 follow-up: @audrasjb
8 months ago

  • Keywords needs-screenshots reporter-feedback added
  • Owner set to audrasjb
  • Status changed from assigned to reviewing

Hi @smallprogrammers thank you for opening this ticket and welcome to WordPress core Trac!

Would you mind uploading some screenshots of the issue?
I can't see what's wrong on the linked website.

Thanks

@audrasjb
8 months ago

can't reproduce the issue on Mac OSX / Chrome

#4 @audrasjb
8 months ago

  • Milestone changed from Awaiting Review to 5.3.2

@Shital Patel
8 months ago

i just removed word-break: break-word; word-wrap: break-word; in *, ::before, ::after { } style.css

@Shital Patel
8 months ago

Before : Screenshot of windows PC firefox browser

@Shital Patel
8 months ago

After : Screenshot of windows PC firefox browser

#5 @mukesh27
8 months ago

  • Focuses css added
  • Keywords has-patch added; needs-screenshots reporter-feedback removed

@audrasjb Replicated the same issue on the Firefox browser in Linux.

@shital-patel If we remove CSS word-break: break-word; word-wrap: break-word; from below then it will create some other text rendering issues.

*, *::before, *::after {
    box-sizing: inherit;
    -webkit-font-smoothing: antialiased;
    word-break: break-word;
    word-wrap: break-word;
}
Last edited 8 months ago by mukesh27 (previous) (diff)

#6 in reply to: ↑ 3 @smallprogrammers
8 months ago

Replying to audrasjb:

Hi @smallprogrammers thank you for opening this ticket and welcome to WordPress core Trac!

Would you mind uploading some screenshots of the issue?
I can't see what's wrong on the linked website.

Thanks

Problem seems with Firefox, i noticed. Not with Chrome or Other browser.:)

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


8 months ago

#8 follow-up: @audrasjb
8 months ago

  • Keywords needs-refresh needs-testing added
  • Milestone changed from 5.3.2 to 5.3.3

Hi there,

Thanks for working on this ticket.
Moving to 5.3.3 as this ticket still needs some work and testing.

Cheers,
Jb

#9 in reply to: ↑ 8 @smallprogrammers
8 months ago

Replying to audrasjb:

Thank you !

#10 @ianbelanger
7 months ago

  • Version changed from 5.3.1 to 5.3

@audrasjb
7 months ago

Reset word-break and word-wrap properties for Twenty Twenty primary and footer navigation menus

#11 @audrasjb
7 months ago

  • Keywords needs-refresh needs-testing removed
  • Status changed from reviewing to accepted

Hi,

In 48970.1.diff I propose to reset word-break and word-wrap properties for Twenty Twenty primary and footer navigation menus. It avoid side effects that could occur with a global reset of those properties.

Tested in various browsers with the reported string সাহায্য, it fixes the issue.

#12 @ianbelanger
7 months ago

  • Milestone changed from 5.3.3 to 5.4

Putting this into the 5.4 milestone so it can be tested and committed in time.

#13 @audrasjb
6 months ago

Hi @ianbelanger, do you think this one is ready to be committed. I think it's ready to go, but it would be great to have your opinion on that :-) Thanks!

#14 @ianbelanger
6 months ago

  • Keywords commit added
  • Owner changed from audrasjb to ianbelanger
  • Status changed from accepted to assigned

#15 @ianbelanger
6 months ago

  • Status changed from assigned to reviewing

The solution does appear to fix the issue with no ill-effects. I will be committing soon.

#16 @ianbelanger
6 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 47192:

Bundled Themes: Twenty Twenty Menu rendering problem Unicode (Bangla).

Fixes a bug where certain words break on to a second line in the primary and footer menus, in certain languages.

Props smallprogrammers, Shital Patel, mukesh27, audrasjb.
Fixes #48970.

#17 @ianbelanger
6 months ago

  • Keywords fixed-major added
  • Milestone changed from 5.4 to 5.3.3
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backport, assigning fixed-major and placing into the 5.3.3 milestone as per the handbook here: https://make.wordpress.org/core/2011/04/06/the-keywords-fixed-major-and-fixed/ and https://make.wordpress.org/core/handbook/contribute/trac/keywords/

#18 @audrasjb
5 months ago

  • Keywords commit fixed-major removed
  • Milestone changed from 5.3.3 to 5.4
  • Resolution set to fixed
  • Status changed from reopened to closed

Moving 5.3.3 Bundled Themes tickets back to milestone 5.4 as RC1 is approaching.
Please don't move them back to 5.3.3 :-)

Note: See TracTickets for help on using tickets.