WordPress.org
Get WordPress

Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #48976, comment 4


Ignore:
Timestamp:
12/16/2019 11:56:33 AM (6 years ago)
Author:
Rarst
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #48976, comment 4

    initial v1  
    1111> it is useful to check the DateTimeZone string with the WordPress string, differently when working dynamically with the php database timezone table ( there should not be a timezone conversion) also previous versions use daylight saving time incorrectly
    1212
    13 I don't follow this part. Yes, historically there are a lot of DST bug caused by use of WP timestamps (sum of a Unix timestamp with time zone offset). Historically WP calculated these by adding offset at ''current'' time, which might be wrong, but doing this is altogether wrong.
     13I don't follow this part. Yes, historically there are a lot of DST bugs caused by use of WP timestamps (sum of a Unix timestamp with time zone offset). Historically WP calculated these by adding offset at ''current'' time, which might be wrong, but doing this is altogether wrong.
    1414
    1515This behavior is preserved for backwards compatibility reasons and optimal action is to use real Unix timestamps and proper DateTimeImmutable/DateTimeZone objects.