WordPress.org

Make WordPress Core

Opened 22 months ago

Closed 7 months ago

#48998 closed enhancement (duplicate)

:active buttons in 5.3.1. all look the same in different user colour schemes

Reported by: studiotwee Owned by:
Milestone: Priority: normal
Severity: normal Version: 5.3.1
Component: Administration Keywords: needs-design-feedback
Focuses: ui, css Cc:

Description

This is a follow-up to #48598.

Are we sure that completely removing the custom button style when not hovering over a button is a good fix for this? In 5.3.1, all buttons have a blue outline, no matter if you are in :hover, :active or in default status.

In the screenshots below you can see the different :hover actions.

Default Colour Scheme
https://i.imgur.com/RbKr49C.png

Midnight Colour Scheme
https://i.imgur.com/vtXECXE.png

Ocean Colour Scheme, non-hover
https://i.imgur.com/QXMUR0p.png

Ocean Colour Scheme, hover
https://i.imgur.com/2BxEdd9.png

I'm all for a11y and this is a vast improvement over how it was, but it seems the buttons lost a bit of flair with this update. The buttons look incredibly boring and are not as in-your-face as they were before.

Change History (9)

#1 @SergeyBiryukov
22 months ago

  • Focuses ui accessibility css added

This ticket was mentioned in Slack in #core by audrasjb. View the logs.


22 months ago

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


20 months ago

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


20 months ago

#5 @afercia
20 months ago

  • Focuses accessibility removed
  • Keywords needs-design-feedback added

This ticket was discussed during today's accessibility bug-scrub. @studiotwee thanks for your report. To our (a11y team) understanding this relates only to the various "Add new" buttons, correct?

The "Add new" use different CSS from the default buttons and they went through some recent CSS changes. Regardless, it appears this is more a design / UI issue rather than an accessibility one. Adjusting the ticket properties accordingly.

This ticket was mentioned in Slack in #design by chaion07. View the logs.


7 months ago

#7 @paaljoachim
7 months ago

Kelly @ryelle This might be a ticket for you to check out as well.

This ticket was mentioned in Slack in #core-css by paaljoachim. View the logs.


7 months ago

#9 @ryelle
7 months ago

  • Milestone Awaiting Review deleted
  • Resolution set to duplicate
  • Status changed from new to closed

The "add new" styles were updated in [48342]/#50537. When hovered or focused, these links get slightly darker. The exception are schemes that are "low contrast", Ocean and Coffee, which get a background color.

Give that this was fixed in another ticket, I'm going to close this issue & mark it a duplicate.

Note: See TracTickets for help on using tickets.