#49 closed defect (bug) (invalid)
Question about redundancy in link-manager.php
Reported by: | JasonV | Owned by: | matt |
---|---|---|---|
Milestone: | Priority: | normal | |
Severity: | trivial | Version: | |
Component: | Administration | Keywords: | |
Focuses: | Cc: |
Description
Before the switch() in link-manager.php, we set all the variables that will be needed whether they are passed via GET or POST, starting at line 55. However, later a number of these variables are set again (for add, editlink, etc.) The only difference is occasionally something like this is used, with '(int)':
$link_id = (int) $_GETlink_id?;
Do we really need '(int)', or can we just stick to setting the variables before the switch()? Seems to me we can just stick to setting them before the switch(), and I'll take care of it if there's no disagreement.
Change History (7)
#2
@
20 years ago
- Owner changed from anonymous to matt
- Resolution changed from 10 to 70
- Status changed from new to closed