WordPress.org

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

#49003 closed defect (bug) (fixed)

Permalink buttons lack color contrast in most alternate color schemes

Reported by: ryelle Owned by: audrasjb
Milestone: 5.3.2 Priority: normal
Severity: normal Version: 5.3.1
Component: Administration Keywords: has-patch has-screenshots commit fixed-major
Focuses: ui, accessibility, css Cc:

Description

When using an alternate color scheme, link Blue or Coffee, the currently-selected permalink tokens are white on a light grey background. The issue affects all buttons that use the .active class, but I only see it used on the permalinks screen.

The .active class style needs to be updated to either use different color variables, or not use variables like the secondary buttons.

Attachments (11)

permalinks.png (69.4 KB) - added by ryelle 2 years ago.
49003.diff (666 bytes) - added by ryelle 2 years ago.
permalinks-with-patch.png (70.3 KB) - added by ryelle 2 years ago.
532-default.png (114.9 KB) - added by audrasjb 2 years ago.
Default
532-blue.png (109.7 KB) - added by audrasjb 2 years ago.
Blue
532-coffee.png (110.6 KB) - added by audrasjb 2 years ago.
coffee
532-ectoplasm.png (103.2 KB) - added by audrasjb 2 years ago.
Ectoplasm
532-light.png (118.1 KB) - added by audrasjb 2 years ago.
Light
532-midnight.png (102.4 KB) - added by audrasjb 2 years ago.
Midnight
532-ocean.png (100.9 KB) - added by audrasjb 2 years ago.
Ocean
532-sunrise.png (117.4 KB) - added by audrasjb 2 years ago.
Sunrise

Download all attachments as: .zip

Change History (19)

@ryelle
2 years ago

@ryelle
2 years ago

#1 @ryelle
2 years ago

49003.diff updates the .active style so it's readable, and tries to bring back a focus state but I'm not sure what that should look like.

The second item in these screenshots are focused (except the default, i forgot to update that screenshot 😅)

https://core.trac.wordpress.org/raw-attachment/ticket/49003/permalinks-with-patch.png

This ticket was mentioned in Slack in #core by presskopp. View the logs.


2 years ago

#3 @audrasjb
2 years ago

  • Keywords needs-patch added
  • Milestone changed from Awaiting Review to 5.3.2

@audrasjb
2 years ago

Default

@audrasjb
2 years ago

Blue

@audrasjb
2 years ago

coffee

@audrasjb
2 years ago

Ectoplasm

@audrasjb
2 years ago

Light

@audrasjb
2 years ago

Midnight

@audrasjb
2 years ago

Ocean

@audrasjb
2 years ago

Sunrise

#4 @audrasjb
2 years ago

  • Keywords has-patch added; needs-patch removed
  • Owner set to audrasjb
  • Status changed from new to reviewing
  • Version set to 5.3.1

Thanks for the patch @ryelle
It looks good to me. See screenshot above (second button is focused).

Testing the patch in the whole WP-Admin interface to check for possible regressions in other places.

#5 @audrasjb
2 years ago

  • Keywords has-screenshots commit added
  • Status changed from reviewing to accepted

I tested the patch on the whole WP-Admin interface and I can confirm it doesn't introduce any regression, even on a multisite installation.

#6 @azaozz
2 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 46967:

Fix the colors in all color schemes for the .active class for buttons.

Props ryelle, audrasjb.
Fixes #49003 for trunk.

#7 @azaozz
2 years ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopen for 5.3.2.

#8 @SergeyBiryukov
2 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 46978:

Administration: Fix the colors in all color schemes for the .active class for buttons.

Props ryelle, audrasjb.
Merges [46967] to the 5.3 branch.
Fixes #49003.

Note: See TracTickets for help on using tickets.