Opened 3 months ago
Closed 3 months ago
#49003 closed defect (bug) (fixed)
Permalink buttons lack color contrast in most alternate color schemes
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 5.3.2 | Priority: | normal |
| Severity: | normal | Version: | 5.3.1 |
| Component: | Administration | Keywords: | has-patch has-screenshots commit fixed-major |
| Focuses: | ui, accessibility, css | Cc: |
Description
When using an alternate color scheme, link Blue or Coffee, the currently-selected permalink tokens are white on a light grey background. The issue affects all buttons that use the .active class, but I only see it used on the permalinks screen.
The .active class style needs to be updated to either use different color variables, or not use variables like the secondary buttons.
Attachments (11)
Change History (19)
This ticket was mentioned in Slack in #core by presskopp. View the logs.
3 months ago
#4
@
3 months ago
- Keywords has-patch added; needs-patch removed
- Owner set to audrasjb
- Status changed from new to reviewing
- Version set to 5.3.1
Thanks for the patch @ryelle
It looks good to me. See screenshot above (second button is focused).
Testing the patch in the whole WP-Admin interface to check for possible regressions in other places.
#5
@
3 months ago
- Keywords has-screenshots commit added
- Status changed from reviewing to accepted
I tested the patch on the whole WP-Admin interface and I can confirm it doesn't introduce any regression, even on a multisite installation.
49003.diff updates the
.activestyle so it's readable, and tries to bring back a focus state but I'm not sure what that should look like.The second item in these screenshots are focused (except the default, i forgot to update that screenshot 😅)