WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

Last modified 5 years ago

#49006 closed defect (bug) (fixed)

Twenty Twenty: Property border-style is overwritten - coding standard.

Reported by: ankitmaru's profile ankitmaru Owned by: ianbelanger's profile ianbelanger
Milestone: 5.4 Priority: normal
Severity: normal Version: 5.3
Component: Bundled Theme Keywords: has-patch
Focuses: ui, css, rtl, coding-standards Cc:

Description

Found some issues in twentytwenty core theme CSS files, Related to coding standards.

Files: editor-style-classic.css, editor-style-classic-rtl.css

Property border-style is overwritten
Property border overwrites property border-style

Attachments (2)

twentytwenty_theme.diff​ (1.4 KB) - added by ankitmaru 5 years ago.
49006.1.diff​ (1.1 KB) - added by ianbelanger 5 years ago.
Update patch to include only Twenty Twenty coding standards fixes

Download all attachments as: .zip

Change History (14)

@ankitmaru
5 years ago

#1 @ankitmaru
5 years ago

  • Summary changed from Property border-style is overwritten on twentytwenty theme css coding standard issues. to Property border-style is overwritten on twentytwenty theme css - coding standard.

#2 @ankitmaru
5 years ago

  • Component changed from Themes to Bundled Theme

#3 @SergeyBiryukov
5 years ago

  • Summary changed from Property border-style is overwritten on twentytwenty theme css - coding standard. to Twenty Twenty: Property border-style is overwritten - coding standard.

#4 @ianbelanger
5 years ago

  • Keywords needs-testing added
  • Milestone changed from Awaiting Review to 5.3.2
  • Version changed from 5.3.1 to 5.3

#5 @audrasjb
5 years ago

  • Milestone changed from 5.3.2 to 5.3.3

Hi and thank you for this ticket,
Moving to milestone 5.3.3 as this patch still needs a review and 5.3.2 is going to be released this week.
Cheers,
Jb

#6 @audrasjb
5 years ago

  • Milestone changed from 5.3.3 to 5.4

Moving all unfixed tickets from 5.3.3 to milestone 5.4, as there is no plan for a 5.3.3 maintenance release for now.

#7 @ianbelanger
5 years ago

  • Keywords commit added; needs-testing removed
  • Owner set to ianbelanger
  • Status changed from new to reviewing

Reviewing for commit.

@ianbelanger
5 years ago

Update patch to include only Twenty Twenty coding standards fixes

#8 @ianbelanger
5 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 47264:

Bundled Themes: Twenty Twenty property border-style is overwritten - coding standard.

Fixes coding standard violations in the classic editor stylesheets.

Props ankitmaru.
Fixes #49006.

#9 @ianbelanger
5 years ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backport.

#10 @ianbelanger
5 years ago

  • Milestone changed from 5.4 to 5.3.3

#11 @audrasjb
5 years ago

  • Keywords commit fixed-major removed
  • Milestone changed from 5.3.3 to 5.4
  • Resolution set to fixed
  • Status changed from reopened to closed

Moving 5.3.3 Bundled Themes tickets back to milestone 5.4 as RC1 is approaching.

Note: See TracTickets for help on using tickets.