Make WordPress Core

Opened 7 years ago

Closed 2 years ago

Last modified 2 years ago

#49008 closed defect (bug) (fixed)

Twenty Twenty: Customizer widgets' edit buttons are partially obstructed on smaller screens

Reported by: sumitsingh Owned by: karmatosed
Priority: normal Milestone: 6.7
Component: Bundled Theme Version: 5.3.1
Severity: normal Keywords: has-patch has-screenshots needs-testing commit
Cc: Focuses: ui, css, administration

Description

Hi,

Design issue in customize.php on Twenty Twenty theme.

For more information sees mention screenshot.

Thanks

Attachments (4)

Customize wpfdemo – Just another WordPress site.png​ (73.0 KB ) - added by sumitsingh 7 years ago.
Bug screenshot file
49008.patch​ (964 bytes ) - added by sabernhardt 5 years ago.
Twenty Twenty at iPad size with adjustment to section-inner class width
2020-customizer-preview-ipad-size-with-patch.png​ (105.5 KB ) - added by sabernhardt 5 years ago.
49008.1.patch​ (1.0 KB ) - added by sabernhardt 2 years ago.
only applies reduced width to the footer nav/widgets container

Download all attachments as: .zip

Change History (12)

#1 @sumitsingh
7 years ago

I have also a solution. changed width: calc(100% - 4rem); to width: calc(100% - 8rem); in wp-content/themes/twentytwenty/style.css

.section-inner {

margin-left: auto;
margin-right: auto;
max-width: 120rem;
width: calc(100% - 8rem);

}

#2 @SergeyBiryukov
7 years ago

  • Component Customize → Bundled Theme
  • Summary Design issue in Ipad → Twenty Twenty: Design issue in Customizer on iPad

@sabernhardt
5 years ago

Twenty Twenty at iPad size with adjustment to section-inner class width

#3 @sabernhardt
5 years ago

  • Keywords has-patch has-screenshots added

Related: #46969 shows the same issue in Twenty Nineteen, and buttons can be cut off even more in Twenty Twenty-One. Ideally, this could be fixed in the Customizer, though I'm not convinced it can.

Twenty Fourteen and Twenty Seventeen already adjust the site title and/or edit buttons.

So 49008.patch​ reduces the width of Twenty Twenty's section-inner class in the Customizer to make space for the footer widgets' Edit buttons, as recommended above.

#4 @sumitsingh
5 years ago

Hi Guys,

Any update about this things?

@sabernhardt
2 years ago

only applies reduced width to the footer nav/widgets container

#5 @sabernhardt
2 years ago

  • Keywords needs-testing added
  • Summary Twenty Twenty: Design issue in Customizer on iPad → Twenty Twenty: Customizer widgets' edit buttons are partially obstructed on smaller screens

The first patch had affected some elements within the content area (on a home page of posts). The revised patch targets only the container for footer navigation and widgets.

#6 @karmatosed
2 years ago

  • Owner set to karmatosed
  • Status new → assigned

Assigning to myself to test and review.

#7 @karmatosed
2 years ago

  • Resolution → fixed
  • Status assigned → closed

In 58778:

Twenty Twenty: Fixes Customizer widget edit buttons being obstructed on smaller screens.

When the screen is smaller the edit buttons are obscured. This resolves that problem for the smaller screens and only targets the container for footer navigation and widgets.

Props sumitsingh, SergeyBiryukov, sabernhardt.
Fixes #49008.

#8 @karmatosed
2 years ago

  • Keywords commit added
  • Milestone Awaiting Review → 6.7
Note: See TracTickets for help on using tickets.