Twenty Twenty: Property font-size is overwritten - coding standard.

[ankitmaru]

Found some issues in twentytwenty core theme CSS files, Related to coding standards.

Files: style.css, style-rtl.css

Property font-size is overwritten

[desrosj]

In 47053:

Bundled Themes: Remove duplicate font-size property in Twenty Twenty.

Props ankitmaru.
Fixes #49015.

[desrosj]

Reopening in case there is a 5.3.3 release and/or a coordinated Twenty Twenty upgrade.

[SergeyBiryukov]

For some context, it used to be a common practice to provide a px fallback for rem units in older bundled themes, from Twenty Twelve to Twenty Seventeen.

That's ​no longer necessary for modern browsers, so Twenty Nineteen and Twenty Twenty don't do that, apart from the instance in .screen-reader-text:focus fixed above.

Note that the current ​recommended CSS for .screen-reader-text:focus no longer includes font-size: 14px. However, it's still referenced in a recent ​How to add and test skip links post on Theme Review Team's blog.

[47053] looks good, but I think the same should be done for Twenty Nineteen for consistency, while we're at it.

[audrasjb]

Moving tickets from 5.3.3 to milestone 5.4, as there is no plan for a 5.3.3 maintenance release for now.

[SergeyBiryukov]

In 47140:

Twenty Nineteen: Remove duplicate font-size property.

The theme does not use a px fallback for rem units anywhere else.

Follow-up to [47053] for Twenty Twenty.

See #49015.

[SergeyBiryukov]

Related: #49006