Make WordPress Core

Opened 5 years ago

Closed 4 years ago

Last modified 4 years ago

#49015 closed defect (bug) (fixed)

Twenty Twenty: Property font-size is overwritten - coding standard.

Reported by: ankitmaru's profile ankitmaru Owned by: desrosj's profile desrosj
Milestone: 5.4 Priority: normal
Severity: normal Version: 5.3
Component: Bundled Theme Keywords: has-patch
Focuses: css, rtl Cc:


Found some issues in twentytwenty core theme CSS files, Related to coding standards.

Files: style.css, style-rtl.css

Property font-size is overwritten

Attachments (1)

twentytwenty_style_css.patch (828 bytes) - added by ankitmaru 5 years ago.

Download all attachments as: .zip

Change History (9)

#1 @desrosj
4 years ago

  • Focuses ui coding-standards removed
  • Keywords needs-testing removed
  • Milestone changed from Awaiting Review to 5.4
  • Owner set to desrosj
  • Status changed from new to reviewing

#2 @desrosj
4 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 47053:

Bundled Themes: Remove duplicate font-size property in Twenty Twenty.

Props ankitmaru.
Fixes #49015.

#3 @desrosj
4 years ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening in case there is a 5.3.3 release and/or a coordinated Twenty Twenty upgrade.

#4 @desrosj
4 years ago

  • Milestone changed from 5.4 to 5.3.3

#5 @SergeyBiryukov
4 years ago

For some context, it used to be a common practice to provide a px fallback for rem units in older bundled themes, from Twenty Twelve to Twenty Seventeen.

That's no longer necessary for modern browsers, so Twenty Nineteen and Twenty Twenty don't do that, apart from the instance in .screen-reader-text:focus fixed above.

Note that the current recommended CSS for .screen-reader-text:focus no longer includes font-size: 14px. However, it's still referenced in a recent How to add and test skip links post on Theme Review Team's blog.

[47053] looks good, but I think the same should be done for Twenty Nineteen for consistency, while we're at it.

Last edited 4 years ago by SergeyBiryukov (previous) (diff)

#6 @audrasjb
4 years ago

  • Keywords fixed-major removed
  • Milestone changed from 5.3.3 to 5.4
  • Resolution set to fixed
  • Status changed from reopened to closed

Moving tickets from 5.3.3 to milestone 5.4, as there is no plan for a 5.3.3 maintenance release for now.

#7 @SergeyBiryukov
4 years ago

In 47140:

Twenty Nineteen: Remove duplicate font-size property.

The theme does not use a px fallback for rem units anywhere else.

Follow-up to [47053] for Twenty Twenty.

See #49015.

Note: See TracTickets for help on using tickets.