#49015 closed defect (bug) (fixed)
Twenty Twenty: Property font-size is overwritten - coding standard.
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.4 | Priority: | normal |
Severity: | normal | Version: | 5.3 |
Component: | Bundled Theme | Keywords: | has-patch |
Focuses: | css, rtl | Cc: |
Description
Found some issues in twentytwenty core theme CSS files, Related to coding standards.
Files: style.css, style-rtl.css
Property font-size is overwritten
Attachments (1)
Change History (9)
#1
@
5 years ago
- Focuses ui coding-standards removed
- Keywords needs-testing removed
- Milestone changed from Awaiting Review to 5.4
- Owner set to desrosj
- Status changed from new to reviewing
#3
@
5 years ago
- Keywords fixed-major added
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening in case there is a 5.3.3 release and/or a coordinated Twenty Twenty upgrade.
#5
@
5 years ago
For some context, it used to be a common practice to provide a px
fallback for rem
units in older bundled themes, from Twenty Twelve to Twenty Seventeen.
That's no longer necessary for modern browsers, so Twenty Nineteen and Twenty Twenty don't do that, apart from the instance in .screen-reader-text:focus
fixed above.
Note that the current recommended CSS for .screen-reader-text:focus no longer includes font-size: 14px
. However, it's still referenced in a recent How to add and test skip links post on Theme Review Team's blog.
[47053] looks good, but I think the same should be done for Twenty Nineteen for consistency, while we're at it.
In 47053: