WordPress.org
Get WordPress

Make WordPress Core

Opened 6 years ago

Closed 5 years ago

Last modified 5 years ago

#49016 closed defect (bug) (wontfix)

Coding Standards: Twenty Seventeen Theme - Use strict comparison in assets/js/html5.js

Reported by: ankitmaru's profile ankitmaru Owned by:
Milestone: Priority: normal
Severity: normal Version: 4.7
Component: Bundled Theme Keywords: has-patch
Focuses: javascript, coding-standards Cc:

Description

Twenty Seventeen Theme - Two types of bugs found
Strict comparison needed in conditions
Strings must use a single quote.

Attachments (1)

twenty_seventeen_html5.js.patch​ (2.2 KB) - added by ankitmaru 6 years ago.

Download all attachments as: .zip

Change History (3)

@ankitmaru
6 years ago

#1 @desrosj
5 years ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed
  • Version changed from 5.3 to 4.7

Hi @ankitmaru,

Thanks for this ticket!

The html5.js file is an external JavaScript file packaged with the theme for maximum HTML5 compatibility in older browsers. This file is intentionally copied verbatim to make updating it easier (changes made in Core won't get overwritten when copying over a new version of the library).

The version of the shiv included in the Twenty Seventeen is the most recent version (which has ​not seen any commit activity since 2017). The browsers and versions it aims to support (IE 6-9, Safari 4.x, iPhone 3.x and Firefox 3.x) are used by very few, and that's likely the reason why it has not been updated in some time. WordPress also no longer supports IE < 11.

For these reasons, I am going to close this out. Any changes that you feel should be made should be reported upstream to the ​shiv's GitHub and can be copied over if an updated version of the shiv is released. But, that task would be the lowest priority IMO.

#2 @ankitmaru
5 years ago

Hello @desrosj
Thank you for the information.

Note: See TracTickets for help on using tickets.