WordPress.org

Make WordPress Core

Opened 8 months ago

Closed 7 months ago

#49018 closed defect (bug) (fixed)

Cleanup CSS for .language-chooser large Continue button

Reported by: garrett-eclipse Owned by: audrasjb
Milestone: 5.3.3 Priority: normal
Severity: normal Version: 5.3
Component: Upgrade/Install Keywords: has-screenshots has-patch fixed-major
Focuses: ui, css, administration Cc:

Description

Hello,

While doing a test install of 5.3.2 RC1 I noticed the 'Continue' word on the first step of the install process wasn't vertically aligned. Inspecting I found it has custom height, font-size, line-height and vertical-align.

At minimum removing the line-height resolves the issue but am wondering if it needs the custom height and font as well.

CSS I'm speaking of;
https://github.com/WordPress/WordPress/blob/db18e7d50b02972431185ff842b9993770893a61/wp-admin/css/install.css#L117-L122

Cheers

Attachments (5)

Screen Shot 2019-12-17 at 2.28.52 PM.png (8.7 KB) - added by garrett-eclipse 8 months ago.
current
Screen Shot 2019-12-17 at 2.29.12 PM.png (8.3 KB) - added by garrett-eclipse 8 months ago.
Removing line-height vertically centers the text.
Screen Shot 2019-12-17 at 2.29.21 PM.png (8.0 KB) - added by garrett-eclipse 8 months ago.
Removing all the custom CSS reduces the size of the button but still looks good
Capture d’écran 2020-01-11 à 18.16.35.png (54.5 KB) - added by audrasjb 7 months ago.
49018.diff
49018.diff (413 bytes) - added by audrasjb 7 months ago.
Install: fixes "Continue" button vertical alignment.

Download all attachments as: .zip

Change History (10)

@garrett-eclipse
8 months ago

Removing line-height vertically centers the text.

@garrett-eclipse
8 months ago

Removing all the custom CSS reduces the size of the button but still looks good

#1 @garrett-eclipse
8 months ago

  • Keywords has-screenshots added

@audrasjb
7 months ago

Install: fixes "Continue" button vertical alignment.

#2 @audrasjb
7 months ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 5.3.3
  • Owner set to audrasjb
  • Status changed from new to accepted

Good catch @garrett-eclipse 👍

In 49018.diff:

  • Install: fixes "Continue" button vertical alignment.

I only kept the font-size CSS declaration.

#3 @SergeyBiryukov
7 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 47070:

Upgrade/Install: Correct vertical alignment for "Continue" button on language selection during the install process.

Props garrett-eclipse, audrasjb.
Fixes #49018.

#4 @SergeyBiryukov
7 months ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for 5.3.3 consideration.

#5 @SergeyBiryukov
7 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 47130:

Upgrade/Install: Correct vertical alignment for "Continue" button on language selection during the install process.

Props garrett-eclipse, audrasjb.
Merges [47070] to the 5.3 branch.
Fixes #49018.

Note: See TracTickets for help on using tickets.