Context Navigation

← Previous Ticket
Next Ticket →

#49018 closed defect (bug) (fixed)

Cleanup CSS for .language-chooser large Continue button

Reported by:	garrett-eclipse	Owned by:	audrasjb
Priority:	normal	Milestone:	5.3.3
Component:	Upgrade/Install	Version:	5.3
Severity:	normal	Keywords:	has-screenshots has-patch fixed-major
Cc:		Focuses:	ui, css, administration

Description

Hello,

While doing a test install of 5.3.2 RC1 I noticed the 'Continue' word on the first step of the install process wasn't vertically aligned. Inspecting I found it has custom height, font-size, line-height and vertical-align.

At minimum removing the line-height resolves the issue but am wondering if it needs the custom height and font as well.

CSS I'm speaking of;
https://github.com/WordPress/WordPress/blob/db18e7d50b02972431185ff842b9993770893a61/wp-admin/css/install.css#L117-L122

Cheers

Attachments (5)

Screen Shot 2019-12-17 at 2.28.52 PM.png (8.7 KB ) - added by garrett-eclipse 7 years ago.: current
Screen Shot 2019-12-17 at 2.29.12 PM.png (8.3 KB ) - added by garrett-eclipse 7 years ago.: Removing line-height vertically centers the text.
Screen Shot 2019-12-17 at 2.29.21 PM.png (8.0 KB ) - added by garrett-eclipse 7 years ago.: Removing all the custom CSS reduces the size of the button but still looks good
Capture d’écran 2020-01-11 à 18.16.35.png (54.5 KB ) - added by audrasjb 7 years ago.: 49018.diff
49018.diff (413 bytes ) - added by audrasjb 7 years ago.: Install: fixes "Continue" button vertical alignment.