Make WordPress Core

Context Navigation

Changes between Version 2 and Version 3 of Ticket #49025, comment 6

Timestamp:: 04/30/2020 11:45:56 AM (6 years ago)
Author:: anonymized_14254218

Legend:

: Unmodified
: Added
: Removed
: Modified

Ticket #49025, comment 6

-              v2
+              v3
 {{{
 function anchor_nav_menu_items($menu){
+        // contains # and does not start with it
+        if (strpos($menu->url,'#')) {
+      // check if this is a relative url
+      // FIXME this condition needs some additional work because it relys on using the host properly
+      //       www.domain.com/foo/bar would probably not match https://domain.com/foo/bar
+                if (strpos(get_site_url(), $menu->url) === false) {
+                        $menu_site_url = get_site_url(null, $menu->url);
+         $menu_site_id = url_to_postid($menu_site_url);
+         // check if the current site is referenced in the menu item
+                        if ($menu_site_id === get_the_id()) {
+                                $menu_site_url_explode = explode('#', $menu->url);
+                                $menu->url = '#' . end($menu_site_url_explode);
+                        }
+                }
+        }
+        return $menu;
+  // contains # and does not start with it
+  if (strpos($menu->url,'#')) {
+    // check if this is a relative url
+    // FIXME this condition needs some additional work because it relys on using the host properly
+    //       www.domain.com/foo/bar would probably not match https://domain.com/foo/bar
+    if (strpos(get_site_url(), $menu->url) === false) {
+      $menu_site_url = get_site_url(null, $menu->url);
+      $menu_site_id = url_to_postid($menu_site_url);
+      // check if the current site is referenced in the menu item
+      if ($menu_site_id === get_the_id()) {
+        $menu_site_url_explode = explode('#', $menu->url);
+        $menu->url = '#' . end($menu_site_url_explode);
+      }
+    }
+  }
+  return $menu;
+}
 …
 . Using the above changes, some functions in the JavaScript can be simplified/removed (see attached index.js.diff and index.js)
 I would create a PR for this, but I do not know where to actually put the php code since I am only used to hooks and filters, not the WordPress core libraries. This is certainly not a final solution, but imo it goes into the right direction.
+I would create a PR for this, but I do not know where to actually put the php code since I am only used to hooks and filters, not the WordPress core libraries.
 You can see a working example on https://foos.bogdan-iws.de/
 Relevant Navigation: "Angebot" -> all sub elements are anchors.
+This is certainly not a final solution, but imo it goes into the right direction. I put fixmes on every line which would need further investigation.