WordPress.org

Make WordPress Core

Opened 10 months ago

Closed 9 months ago

Last modified 9 months ago

#49043 closed defect (bug) (fixed)

Form Inputs for Right Now widget in multisite no longer line up

Reported by: williampatton Owned by: SergeyBiryukov
Milestone: 5.4 Priority: normal
Severity: normal Version: 5.4
Component: Networks and Sites Keywords: has-screenshots has-patch
Focuses: ui, css, multisite Cc:

Description

On multisite the Right Now widget has 2 inputs with buttons. One to search users and one to search sites.

With the recent UI changes these inputs no longer line up like they used to and the button wraps with no upper margins. It looks out of place.

One fix is to adjust the size attribute on the inputs from 30 to instead be 28. It's not ideal but it kind of works. A CSS based approach is likely the better option.

Attachments (3)

Screenshot from 2019-12-19 14-34-42.png (15.7 KB) - added by williampatton 10 months ago.
Right Now dashboard widget on multisite with form layout issues
Screenshot from 2019-12-19 14-41-31.png (12.4 KB) - added by williampatton 10 months ago.
With the widget inputs size adjusted to be '28'
49043.diff (1.3 KB) - added by bordoni 9 months ago.
Modify the size of the input's on Dashboard Widget for Multisite to be 28 instead of 30.

Download all attachments as: .zip

Change History (9)

@williampatton
10 months ago

Right Now dashboard widget on multisite with form layout issues

@williampatton
10 months ago

With the widget inputs size adjusted to be '28'

This ticket was mentioned in Slack in #design by williampatton. View the logs.


10 months ago

#2 @SergeyBiryukov
10 months ago

  • Component changed from General to Administration
  • Milestone changed from Awaiting Review to 5.4

@bordoni
9 months ago

Modify the size of the input's on Dashboard Widget for Multisite to be 28 instead of 30.

#3 @bordoni
9 months ago

  • Keywords has-patch added; needs-patch removed

Included a Patch with modification suggested by @williampatton.

#4 @SergeyBiryukov
9 months ago

  • Component changed from Administration to Networks and Sites

#5 @SergeyBiryukov
9 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 47151:

Networks and Sites: Reduce max-width for user and site search inputs on Dashboard screen in Network Admin.

This ensures that the inputs don't push the buttons to the next line.

Props williampatton, bordoni.
Fixes #49043.

#6 in reply to: ↑ description @SergeyBiryukov
9 months ago

Replying to williampatton:

With the recent UI changes these inputs no longer line up like they used to and the button wraps with no upper margins. It looks out of place.

Thanks for the report! Just in case, could you double-check that [47151] resolves the issue? It did in my testing, though the box looks a bit different on my install (Windows 10, Chrome 79.0.3945.130).

Note: See TracTickets for help on using tickets.