WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Last modified 5 years ago

#49046 reviewing enhancement

Add filter to send_confirmation_on_profile_email()

Reported by: jfarthing84's profile jfarthing84 Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: Future Release Priority: normal
Severity: normal Version:
Component: Users Keywords: has-patch dev-feedback needs-refresh needs-dev-note
Focuses: Cc:

Description

To be consistent with the other user notifications, all aspects of this email should be filterable, not just the content.

Attachments (1)

49046.patch​ (1.8 KB) - added by jfarthing84 5 years ago.

Download all attachments as: .zip

Change History (6)

@jfarthing84
5 years ago

#1 @SergeyBiryukov
5 years ago

  • Milestone changed from Awaiting Review to 5.4
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#2 @wpamitkumar
5 years ago

@jfarthing84 I think you should use apply_filters hook as wp_new_user_notification_email instead of new_user_email_notification in your 49046.patch .

$new_user_email_notification = apply_filters( 'wp_new_user_notification_email', $new_user_email_notification, $current_user, $sitename );

$new_user_email_notification = apply_filters( 'new_user_email_notification', $new_user_email_notification, $current_user, $sitename );

#3 @davidbaumwald
5 years ago

@SergeyBiryukov Is this still a good candidate for 5.4? Latest patch is still applying cleanly.

This ticket was mentioned in ​Slack in #core by david.baumwald. ​View the logs.
5 years ago

#5 @davidbaumwald
5 years ago

  • Keywords needs-refresh needs-dev-note added
  • Milestone changed from 5.4 to Future Release

This ticket still needs a review, and with 5.4 Beta 1 landing tomorrow, this is being moved to Future Release. If any maintainer or committer feels this can be included in 5.4 or wishes to assume ownership during a specific cycle, feel free to update the milestone accordingly.

Also, marking for a refresh for whatever cycle it lands in and it needs a small call-out on the Misc Dev Note.

Note: See TracTickets for help on using tickets.