WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

#49052 closed defect (bug) (fixed)

Twenty Nineteen: Coding Standard issue in twentynineteen_hsl_hex()

Reported by: ankitmaru's profile ankitmaru Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.6 Priority: normal
Severity: normal Version: 5.0
Component: Bundled Theme Keywords: has-patch
Focuses: coding-standards Cc:

Description

Coding Standards: Undefined variable warning showing on twentynineteen/inc/template-functions.php

Variable declaration not as per PHP standards.

Attachments (2)

twentynineteen_theme_code_standard.diff​ (618 bytes) - added by ankitmaru 5 years ago.
49052.diff​ (615 bytes) - added by sabernhardt 4 years ago.
same change as in the earlier patch, but in helper-functions.php

Download all attachments as: .zip

Change History (6)

@ankitmaru
5 years ago

#1 @ianbelanger
5 years ago

  • Milestone changed from Awaiting Review to Future Release
  • Summary changed from Coding Standards: twentynineteen/inc/template-functions.php to Twenty Nineteen: Coding Standard issue in twentynineteen/inc/template-functions.php
  • Version changed from 5.3 to 5.0

@sabernhardt
4 years ago

same change as in the earlier patch, but in helper-functions.php

#2 @sabernhardt
4 years ago

  • Summary changed from Twenty Nineteen: Coding Standard issue in twentynineteen/inc/template-functions.php to Twenty Nineteen: Coding Standard issue in twentynineteen_hsl_hex()

@ankitmaru Thanks for the patch! I simply refreshed it after twentynineteen_hsl_hex() moved to a helper-functions.php file (see #45984).

#3 @SergeyBiryukov
4 years ago

  • Milestone changed from Future Release to 5.6

#4 @SergeyBiryukov
4 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 49602:

Twenty Nineteen: Remove unnecessary references to some variables in twentynineteen_hsl_hex() before they are defined.

Props ankitmaru, sabernhardt.
Fixes #49052.

Note: See TracTickets for help on using tickets.