WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Closed 6 years ago

#49052 closed defect (bug) (fixed)

Twenty Nineteen: Coding Standard issue in twentynineteen_hsl_hex()

Reported by: ankitmaru Owned by: SergeyBiryukov
Priority: normal Milestone: 5.6
Component: Bundled Theme Version: 5.0
Severity: normal Keywords: has-patch
Cc: Focuses: coding-standards

Description

Coding Standards: Undefined variable warning showing on twentynineteen/inc/template-functions.php

Variable declaration not as per PHP standards.

Attachments (2)

twentynineteen_theme_code_standard.diff​ (618 bytes ) - added by ankitmaru 7 years ago.
49052.diff​ (615 bytes ) - added by sabernhardt 6 years ago.
same change as in the earlier patch, but in helper-functions.php

Download all attachments as: .zip

Change History (6)

@ankitmaru
7 years ago

#1 @ianbelanger
6 years ago

  • Milestone Awaiting Review → Future Release
  • Summary Coding Standards: twentynineteen/inc/template-functions.php → Twenty Nineteen: Coding Standard issue in twentynineteen/inc/template-functions.php
  • Version 5.3 → 5.0

@sabernhardt
6 years ago

same change as in the earlier patch, but in helper-functions.php

#2 @sabernhardt
6 years ago

  • Summary Twenty Nineteen: Coding Standard issue in twentynineteen/inc/template-functions.php → Twenty Nineteen: Coding Standard issue in twentynineteen_hsl_hex()

@ankitmaru Thanks for the patch! I simply refreshed it after twentynineteen_hsl_hex() moved to a helper-functions.php file (see #45984).

#3 @SergeyBiryukov
6 years ago

  • Milestone Future Release → 5.6

#4 @SergeyBiryukov
6 years ago

  • Owner set to SergeyBiryukov
  • Resolution → fixed
  • Status new → closed

In 49602:

Twenty Nineteen: Remove unnecessary references to some variables in twentynineteen_hsl_hex() before they are defined.

Props ankitmaru, sabernhardt.
Fixes #49052.

Note: See TracTickets for help on using tickets.