Twenty Twenty: Comments report

[Parvand]

problem in comments.php
at line 35 where it starts:

} elseif ( '1' === $comments_number ) {

its not work for translate. I think it should be as follows:

} elseif ( '1' == $comments_number ) {

i change and it work now.

in twentynineteen its :

if ( '1' == $discussion->responses ) {

is that problem or not?

[SergeyBiryukov]

Hi there, welcome to WordPress Trac! Thanks for the report.

That condition is correct as is, since get_comments_number() returns a numeric string, not an integer. It's also the same in other bundled themes (except for Twenty Nineteen). See #38369 for more details.

Could you clarify what exactly is the problem wit translations?

[desrosj]

@Parvand I am going to close this out because the lines you mentioned are correct from a code standpoint.

If you are still experiencing issues, please reopen the ticket and add more details about the problem with translations so it can be troubleshooted further.

[juliobox]

Hey there
The issue is still there, but here is the real bug :

Line 26 : $comments_number = absint( get_comments_number() );
Line 36 : } elseif ( '1' === $comments_number ) {

This is why this if can't be triggered.
The patch is : } elseif ( 1 === $comments_number ) {

Have a good day

[Mista-Flo]

Good catch, I agree with Julio.

[benjamingosset]

Apply patch

[benjamingosset]

Before patch

[benjamingosset]

After patch

[benjamingosset]

Hey,

This is my first contribution, i applied the patch proposed by Julio.
I added screenshots before/after applying patch, it seems ok.

Could someone check if everything is ok ?

Thanks

[elimuhub]

Replying to SergeyBiryukov:

Hi there, welcome to WordPress Trac! Thanks for the report.

That condition is correct as is, since get_comments_number() returns a numeric string, not an integer. It's also the same in other bundled themes (except for Twenty Nineteen). See #38369 for more details.

Could you clarify what exactly is the problem with translations?

[SergeyBiryukov]

#50221 was marked as a duplicate.

[audrasjb]

Twenty Fifteen: translation correctly applied.

[audrasjb]

Twenty Sixteen: translation correctly applied.

[audrasjb]

Twenty Seventeen: translation correctly applied.

[audrasjb]

Twenty Nineteen: translation correctly applied.

[audrasjb]

Twenty Twenty: translation will never be applied.

[audrasjb]

@SergeyBiryukov I think the previous commenters are right, Twenty Twenty will never apply this translation.
The current patch fixes the issue on my side.

Marking this ticket for commit.

[audrasjb]

PS: I tested all the other themes and they are all displaying the correct translation.

[opurockey]

Apply patch

[ianbelanger]

Reviewing for commit.

[ianbelanger]

In 47941:

Bundled Themes: Twenty Twenty number of replies not translatable.

Fixes the issue by removing the single quote from around the 1 in the elseif conditional of the comments template.

Props Parvand, SergeyBiryukov, desrosj, juliobox, Mista-Flo, benjamingosset, audrasjb, opurockey.
Fixes #49058.

[ianbelanger]

Reopening for backport.

[desrosj]

With 5.5 just under 5 weeks away, there is no 5.4.3 planned. Moving back to the 5.5 milestone.