WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 4 years ago

#49088 closed enhancement (fixed)

Twenty Twenty: Add icon for g.page links (Google business profile)

Reported by: argentite's profile argentite Owned by: ianbelanger's profile ianbelanger
Milestone: 5.4.2 Priority: normal
Severity: normal Version: 5.3
Component: Bundled Theme Keywords: has-patch commit fixed-major
Focuses: Cc:

Description

Google provides URLs at the domain g.page for Google Business profiles. Example: ​https://g.page/sonajhuri-inn?gm
The Twenty Twenty theme includes a few icons for some popular sites and also a SVG "Google" icon at https://core.trac.wordpress.org/browser/trunk/src/wp-content/themes/twentytwenty/classes/class-twentytwenty-svg-icons.php#L207.
This icon should be enabled by just adding a few lines at https://core.trac.wordpress.org/browser/trunk/src/wp-content/themes/twentytwenty/classes/class-twentytwenty-svg-icons.php#L155 for g.page domain. I have successfully tested this on my site.

Attachments (2)

49088.diff​ (594 bytes) - added by mayankmajeji 4 years ago.
Added icon for g.page links
49088.1.diff​ (511 bytes) - added by ianbelanger 4 years ago.
patch refresh

Download all attachments as: .zip

Change History (12)

#1 @SergeyBiryukov
5 years ago

  • Component changed from Themes to Bundled Theme
  • Summary changed from Add icon for g.page links (Google business profile) to Twenty Twenty: Add icon for g.page links (Google business profile)

#2 @ianbelanger
5 years ago

  • Keywords needs-patch reporter-feedback added
  • Severity changed from trivial to normal
  • Version changed from 5.3.2 to 5.3

Thanks for the ticket @argentite, this seems like it would be a good addition to Twenty Twenty. Could you please submit a patch or post your code on this ticket. Thanks

#3 @argentite
5 years ago

Adding the following at line 155 in classes/class-twentytwenty-svg-icons.php worked for me:

			'google'    => array(
				'g.page',
			),

Also icons for wa.me (WhatsApp Messenger), m.me (Facebook Messenger), t.me (Telegram Messenger) are missing but I'm not sure if they are considered as social media. :-)

@mayankmajeji
4 years ago

Added icon for g.page links

#4 @mayankmajeji
4 years ago

  • Keywords has-patch added; needs-patch removed

@ianbelanger
4 years ago

patch refresh

#5 @ianbelanger
4 years ago

  • Keywords commit added; reporter-feedback removed
  • Milestone changed from Awaiting Review to 5.5
  • Owner set to ianbelanger
  • Status changed from new to reviewing

Patch looked good, just needed a refresh to apply. I'll be committing this after the next release.

#6 @ianbelanger
4 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 47795:

Bundled Themes: Twenty Twenty add icon for g.page links.

Adds the option to use a g.page url for the social menu.

Props argentite, mayankmajeji.
Fixes #49088.

#7 @ianbelanger
4 years ago

  • Keywords fixed-major added
  • Milestone changed from 5.5 to 5.4.2
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for backport.

#8 @hanswitteprins
4 years ago

When I was looking through the changelog of version 1.3, I found that the log of this issue points to ticket 49254 instead of this one. Thought you might want to know, in case you want to correct.

#9 @ianbelanger
4 years ago

Thanks for bringing this to my attention. I have updated the Twenty Twenty Changelog with the correct link: ​https://wordpress.org/support/article/twenty-twenty-changelog/

#10 @whyisjake
4 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 47828:

Bundled Themes: Twenty Twenty add icon for g.page links.
Adds the option to use a g.page url for the social menu.

This brings the changes from [47795] to the 5.4 branch.

Props argentite, mayankmajeji.
Fixes #49088.

Note: See TracTickets for help on using tickets.