WordPress.org

Make WordPress Core

Opened 3 months ago

Last modified 6 days ago

#49088 new enhancement

Twenty Twenty: Add icon for g.page links (Google business profile)

Reported by: argentite Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 5.3
Component: Bundled Theme Keywords: reporter-feedback has-patch
Focuses: Cc:

Description

Google provides URLs at the domain g.page for Google Business profiles. Example: https://g.page/sonajhuri-inn?gm
The Twenty Twenty theme includes a few icons for some popular sites and also a SVG "Google" icon at https://core.trac.wordpress.org/browser/trunk/src/wp-content/themes/twentytwenty/classes/class-twentytwenty-svg-icons.php#L207.
This icon should be enabled by just adding a few lines at https://core.trac.wordpress.org/browser/trunk/src/wp-content/themes/twentytwenty/classes/class-twentytwenty-svg-icons.php#L155 for g.page domain. I have successfully tested this on my site.

Attachments (1)

49088.diff (594 bytes) - added by mayankmajeji 6 days ago.
Added icon for g.page links

Download all attachments as: .zip

Change History (5)

#1 @SergeyBiryukov
3 months ago

  • Component changed from Themes to Bundled Theme
  • Summary changed from Add icon for g.page links (Google business profile) to Twenty Twenty: Add icon for g.page links (Google business profile)

#2 @ianbelanger
3 months ago

  • Keywords needs-patch reporter-feedback added
  • Severity changed from trivial to normal
  • Version changed from 5.3.2 to 5.3

Thanks for the ticket @argentite, this seems like it would be a good addition to Twenty Twenty. Could you please submit a patch or post your code on this ticket. Thanks

#3 @argentite
2 months ago

Adding the following at line 155 in classes/class-twentytwenty-svg-icons.php worked for me:

			'google'    => array(
				'g.page',
			),

Also icons for wa.me (WhatsApp Messenger), m.me (Facebook Messenger), t.me (Telegram Messenger) are missing but I'm not sure if they are considered as social media. :-)

@mayankmajeji
6 days ago

Added icon for g.page links

#4 @mayankmajeji
6 days ago

  • Keywords has-patch added; needs-patch removed
Note: See TracTickets for help on using tickets.