WordPress.org
Get WordPress

Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#49108 closed defect (bug) (fixed)

Coding Standards: src/js/media/controllers/library.js

Reported by: ankitmaru's profile ankitmaru Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 5.4 Priority: normal
Severity: normal Version: 5.3.2
Component: Media Keywords: has-patch
Focuses: javascript, coding-standards Cc:

Description

Coding Standard: Expected a conditional expression and instead saw an assignment.

Attachments (1)

if_condition_assignement_bug_library_js_fix.diff​ (1.0 KB) - added by ankitmaru 5 years ago.

Download all attachments as: .zip

Change History (3)

@ankitmaru
5 years ago

#1 @SergeyBiryukov
5 years ago

  • Component changed from General to Media
  • Milestone changed from Awaiting Review to 5.4
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#2 @SergeyBiryukov
5 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 47030:

Coding Standards: Move assignment out of condition in js/media/controllers/library.js.

Props ankitmaru.
Fixes #49108.

Note: See TracTickets for help on using tickets.