WordPress.org
Get WordPress

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#49108 closed defect (bug) (fixed)

Coding Standards: src/js/media/controllers/library.js

Reported by: ankitmaru Owned by: SergeyBiryukov
Priority: normal Milestone: 5.4
Component: Media Version: 5.3.2
Severity: normal Keywords: has-patch
Cc: Focuses: javascript, coding-standards

Description

Coding Standard: Expected a conditional expression and instead saw an assignment.

Attachments (1)

if_condition_assignement_bug_library_js_fix.diff​ (1.0 KB ) - added by ankitmaru 7 years ago.

Download all attachments as: .zip

Change History (3)

@ankitmaru
7 years ago

#1 @SergeyBiryukov
7 years ago

  • Component General → Media
  • Milestone Awaiting Review → 5.4
  • Owner set to SergeyBiryukov
  • Status new → reviewing

#2 @SergeyBiryukov
7 years ago

  • Resolution → fixed
  • Status reviewing → closed

In 47030:

Coding Standards: Move assignment out of condition in js/media/controllers/library.js.

Props ankitmaru.
Fixes #49108.

Note: See TracTickets for help on using tickets.