Make WordPress Core

Opened 5 years ago

Closed 5 years ago

#49115 closed defect (bug) (fixed)

Published on select dropdown has a line height issue in WP Admin

Reported by: pratik-jain's profile Pratik Jain Owned by: audrasjb's profile audrasjb
Milestone: 5.3.3 Priority: normal
Severity: normal Version: 5.3.2
Component: Editor Keywords: has-patch commit fixed-major
Focuses: ui, css, administration Cc:

Description

In WordPress admin "Published on" select dropdown has a line height issue.

Attachments (6)

Screenshot.png (7.9 KB) - added by Pratik Jain 5 years ago.
Post Edit Screen
49115.diff (329 bytes) - added by justinahinon 5 years ago.
Fix the line-height issue on "Published on" wp-admin/css/edit
49115.2.diff (329 bytes) - added by justinahinon 5 years ago.
Fix the line-height issue on "Published on" wp-admin/css/edit.css
49115.3.diff (373 bytes) - added by Pratik Jain 5 years ago.
Fix the line-height issue on "Published on" select dropdown wp-admin/css/edit
test-49115.2.diff.png (34.5 KB) - added by audrasjb 5 years ago.
Testing 49115.2.diff
test-49115.3.diff.png (34.8 KB) - added by audrasjb 5 years ago.
Testing 49115.3.diff

Download all attachments as: .zip

Change History (12)

@Pratik Jain
5 years ago

Post Edit Screen

#1 @SergeyBiryukov
5 years ago

  • Component changed from General to Editor

@justinahinon
5 years ago

Fix the line-height issue on "Published on" wp-admin/css/edit

@justinahinon
5 years ago

Fix the line-height issue on "Published on" wp-admin/css/edit.css

#2 @Pratik Jain
5 years ago

Fix the line-height issue on "Published on" select dropdown wp-admin/css/edit

@Pratik Jain
5 years ago

Fix the line-height issue on "Published on" select dropdown wp-admin/css/edit

@audrasjb
5 years ago

Testing 49115.2.diff

@audrasjb
5 years ago

Testing 49115.3.diff

#3 @audrasjb
5 years ago

  • Keywords has-patch commit added
  • Milestone changed from Awaiting Review to 5.3.3
  • Owner set to audrasjb
  • Status changed from new to accepted

Hi, thanks for the ticket and for the patches,

I tested the two last patches and 49115.2.diff is a little off-center, while 49115.3.diff looks good to me.
Adding this to the next minor version milestone, as it's a regression from 5.3.

#4 @SergeyBiryukov
5 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 47072:

Editor: Correct vertical alignment for "Published on" month dropdown in Classic Editor.

Props pratik-jain, justinahinon, audrasjb.
Fixes #49115.

#5 @SergeyBiryukov
5 years ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening for 5.3.3 consideration.

#6 @SergeyBiryukov
5 years ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 47129:

Editor: Correct vertical alignment for "Published on" month dropdown in Classic Editor.

Props pratik-jain, justinahinon, audrasjb.
Merges [47072] to the 5.3 branch.
Fixes #49115.

Note: See TracTickets for help on using tickets.