#49122 closed enhancement (fixed)
Coding Standard : Javascript - /src/js/_enqueues/wp/customize/base.js
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 5.4 | Priority: | normal |
| Severity: | normal | Version: | 5.3.2 |
| Component: | Customize | Keywords: | has-patch |
| Focuses: | javascript, coding-standards | Cc: |
Description
Coding Standard : Javascript - /src/js/_enqueues/wp/customize/base.js
Attachments (1)
Change History (5)
#1
@
6 years ago
- Component changed from General to Customize
- Milestone changed from Awaiting Review to 5.4
- Owner set to SergeyBiryukov
- Status changed from new to reviewing
#3
@
6 years ago
Noting that [r47038] also added an equality check change to a strict equality check, which looks good here - however in some circumstances this might break intended functionality, so its important to review these types of changes very carefully.
@ankitmaru & @SergeyBiryukov I appreciate your effort and contributions here, however I'm concerned that these changes are being made to refactor old coding to conform to coding standards for standards sake only. I'm all for coding standards, and improving our code quality, and in fact we have been working towards adding Prettier so our agreement can be enforced. I'm mainly concerned that the refactoring effort here might be wasted effort, or introduce unintended side effects. See https://make.wordpress.org/core/handbook/contribute/code-refactoring/.
If there is a desire to refactor old code to bring it up to standards, I would like to coordinate the effort with our JS team, I would be happy to bring it up at our next weekly JS chat.
In 47038: