#49144 closed enhancement (fixed)
Build Tools: do not include assets for JS dependencies that do not exist
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.4 | Priority: | normal |
Severity: | normal | Version: | 5.4 |
Component: | Build/Test Tools | Keywords: | has-patch commit |
Focuses: | javascript | Cc: |
Description
This is a follow-up for #48154, where we started including *.asset.php
files to declare package dependencies.
This works well but creates warnings in environments where the package does not exist because WordPress was not fully built. Could we bail in those scenarios and not try to include the file at all?
Attachments (2)
Change History (7)
#2
@
5 years ago
Code is now also available at https://github.com/WordPress/wordpress-develop/pull/129 if needed to check Travis results.
Note: See
TracTickets for help on using
tickets.
I noticed that too when running unit tests against trunk in a plugin. Would be good to fix this, and the patch looks reasonable for that!