Make WordPress Core

Opened 7 years ago

Closed 7 years ago

Last modified 7 years ago

#49170 closed defect (bug) (fixed)

incorrect description of return value in DocBlock of WP_List_Table::handle_row_actions()

Reported by: pbiron Owned by: SergeyBiryukov
Priority: normal Milestone: 5.4
Component: Administration Version:
Severity: normal Keywords: has-patch
Cc: Focuses: docs

Description

Currently the text reads:

The row actions HTML, or an empty string if the current column is the primary column.

and it should read:

The row actions HTML, or an empty string if the current column is not the primary column.

Attachments (1)

49170.diff (1.3 KB ) - added by pbiron 7 years ago.

Download all attachments as: .zip

Change History (5)

@pbiron
7 years ago

#1 @pbiron
7 years ago

  • Keywords has-patch added

#2 @SergeyBiryukov
7 years ago

  • Milestone Awaiting Review5.4
  • Owner set to SergeyBiryukov
  • Status newreviewing

#3 @SergeyBiryukov
7 years ago

  • Resolutionfixed
  • Status reviewingclosed

In 47058:

Docs: Correct @return description for WP_List_Table::handle_row_actions().

Props pbiron.
Fixes #49170.

#4 @SergeyBiryukov
7 years ago

In 47059:

Docs: Synchronize @return descriptions for ::handle_row_actions() methods in list tables.

Make sure WP_Comments_List_Table::handle_row_actions() and WP_MS_Sites_List_Table::handle_row_actions() return a string, for consistency with other classes.

See #49170, #48303.

Note: See TracTickets for help on using tickets.