Opened 7 years ago
Closed 7 years ago
#49174 closed defect (bug) (fixed)
Incorrect usage of <label> in wp-signup.php
| Reported by: | audrasjb | Owned by: | audrasjb |
|---|---|---|---|
| Priority: | normal | Milestone: | 5.4 |
| Component: | Login and Registration | Version: | |
| Severity: | normal | Keywords: | good-first-bug has-patch commit |
| Cc: | Focuses: | accessibility, multisite |
Description
There is a duplicate/wrong use of <label> in wp-signup.php:
https://core.trac.wordpress.org/browser/branches/5.3/src/wp-signup.php#L201
The text "Privacy:" is not a label but rather a section title in my opinion. Ideally, it could be transformed into a proper heading. By the way, a very quick fix would be to simply remove the <label> HTML tag that wraps this text.
Attachments (1)
Change History (4)
#2
@
7 years ago
- Keywords commit added; needs-testing removed
- Milestone Awaiting Review → 5.4
- Owner set to
- Status new → accepted
Thanks for the patch @vaishalipanchal, looks good to me.
Adding commit keyword and milestoning to 5.4.
Please note: we use good-first-bug keyword to identify easy bugfixes so new contributors can learn how to make a patch and contribute to WP Core. It's a very helpful way to onboard new contributors, so please remember to give them priority on those :-)
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
Patch.