WordPress.org

Make WordPress Core

Opened 12 days ago

Closed 8 days ago

#49174 closed defect (bug) (fixed)

Incorrect usage of <label> in wp-signup.php

Reported by: audrasjb Owned by: audrasjb
Milestone: 5.4 Priority: normal
Severity: normal Version:
Component: Login and Registration Keywords: good-first-bug has-patch commit
Focuses: accessibility, multisite Cc:
PR Number:

Description

There is a duplicate/wrong use of <label> in wp-signup.php:
https://core.trac.wordpress.org/browser/branches/5.3/src/wp-signup.php#L201

The text "Privacy:" is not a label but rather a section title in my opinion. Ideally, it could be transformed into a proper heading. By the way, a very quick fix would be to simply remove the <label> HTML tag that wraps this text.

Attachments (1)

49174.diff (508 bytes) - added by vaishalipanchal 11 days ago.
Patch.

Download all attachments as: .zip

Change History (4)

@vaishalipanchal
11 days ago

Patch.

#1 @vaishalipanchal
11 days ago

  • Keywords has-patch added; needs-patch removed

#2 @audrasjb
11 days ago

  • Keywords commit added; needs-testing removed
  • Milestone changed from Awaiting Review to 5.4
  • Owner set to audrasjb
  • Status changed from new to accepted

Thanks for the patch @vaishalipanchal, looks good to me.

Adding commit keyword and milestoning to 5.4.

Please note: we use good-first-bug keyword to identify easy bugfixes so new contributors can learn how to make a patch and contribute to WP Core. It's a very helpful way to onboard new contributors, so please remember to give them priority on those :-)

#3 @SergeyBiryukov
8 days ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 47074:

Login and Registration: Remove duplicate <label> tag from show_blog_form() in wp-signup.php.

Props vaishalipanchal, audrasjb.
Fixes #49174.

Note: See TracTickets for help on using tickets.