Opened 5 years ago
Closed 5 years ago
#49181 closed defect (bug) (fixed)
Clarify accepted values for style argument in wp_list_comments()
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 5.5 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Comments | Keywords: | good-first-bug has-patch |
Focuses: | docs | Cc: |
Description
wp_list_comments()
accepts style
as part of the arguments it passes to the comment walker to determine how a list of comments should be displayed.
- If
div
is passed, no markup is output in the walker'sstart_lvl()
method. - If
ol
is passed,ol
markup is output. - If
ul
or any other value is passed,ul
markup is output.
The functions docs imply right now that only ol
and ul
are valid. It should clarify that div
will result in no additional list markup.
Attachments (1)
Change History (7)
#3
@
5 years ago
- Keywords has-patch added; needs-patch removed
- Milestone changed from Awaiting Review to 5.5
- Owner set to SergeyBiryukov
- Status changed from new to reviewing
Note: See
TracTickets for help on using
tickets.
The documentation can be found here:
https://developer.wordpress.org/reference/functions/wp_list_comments/#comments
The code is here:
wp-includes/class-walker-comment.php#L58