WordPress.org

Make WordPress Core

Opened 3 months ago

Last modified 2 weeks ago

#49182 new enhancement

Unmask password button

Reported by: bernardroux Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 2.7
Component: Posts, Post Types Keywords: needs-patch good-first-bug
Focuses: Cc:

Description

Hello,
I would like to add an “eye” (connection protected pagefile) of visibility of the Password because many people without a numeric keypad Keyboard believe entering numbers while entering lowercase type [in French : é ”' (-è_çà] the fact that only * appear when connecting to protected pages (protected page file)
Regards

Change History (8)

#1 follow-up: @johnbillion
3 months ago

  • Component changed from General to Posts, Post Types
  • Keywords needs-patch good-first-bug added
  • Version changed from 5.3.2 to 2.7

This functionality exists in a few places within the WordPress admin area. It should be possible to add it to the password protected post form too.

#2 in reply to: ↑ 1 @apieschel
3 months ago

Replying to johnbillion:

This functionality exists in a few places within the WordPress admin area. It should be possible to add it to the password protected post form too.

I've been looking into a patch, and adding the markup to get_the_password_form() in wp-includes/post-template.php looks to be relatively straightforward. However, it doesn't seem right to load the same Javascript functionality as is loaded for the admin views, such as the bindToggleButton() function in wp-admin/js/user-profile.js, since this will be for a front end post view.

For something like this, does it make sense to create a new script file in wp-includes/js/ ?

If the markup for the admin functionality is emulated, there's also the issue of dashicons not being enqueued by default on the front end (unless I'm mistaken), and whether or not we would want to add some default styling of the password toggle button similar to the admin style, as well.

Last edited 3 months ago by apieschel (previous) (diff)

#3 @bernardroux
3 months ago

At @johnbillion and @apieschel.
Thank you for your quick responses.
"For something like this, does it make sense to create a new script file in wp-includes/js/"
I think this suggestion is a good idea.
Note: I am not a champion of JS scripts at all and and it would be better to have the file in its entirety.
Thanks you anywhere

#4 @carriganvb
3 weeks ago

Hello, first time contributor here.

@bernardroux I'm trying to find out which password entry you'd like to see updated. I'm running 5.3.2 and wp-login.php has a password field with an eye button to toggle password visibility.

So, perhaps this enhancement has already been delivered? Or perhaps there's another place where the password field can be found in wordpress where you'd like to see the eye toggler.

Let me know if I need to clarify or if I have misunderstood the enhancement request.

-Carrigan

#5 @bernardroux
3 weeks ago

Hello Carrigan,
When you have a publication (page) which is password protected, you need to fill the password field. It should be nice to have an eye button to toggle password visibility.
I don't speak for about the password field of the wp-login.php.
Thanks a lot
Bernard

#6 @carriganvb
3 weeks ago

Thank you @bernardroux I'll take a look and see if I can't find where the publication password appears.

Thanks,
-Carrigan

#7 @carriganvb
2 weeks ago

@bernardroux OK I found what you mean. The password on the published pages that are password protected. I think I understand the problem... Now to fix it!

#8 @bernardroux
2 weeks ago

To Carrigan,
That exactly what I meaned.
Thank you for your consideration
I wait you fix it!
Thank's a lot
Bernard

Note: See TracTickets for help on using tickets.