WordPress.org

Make WordPress Core

Opened 7 months ago

Last modified 4 months ago

#49185 new defect (bug)

Option to use text link instead of auto embed.

Reported by: paaljoachim Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Embeds Keywords:
Focuses: Cc:

Description

Adding links. If an link goes to another WordPress site we will see an auto embed.
It would be great with an option to either auto embed or show a regular text link.

I made the Gutenberg issue here:
https://github.com/WordPress/gutenberg/issues/15102
Another similar issue: https://github.com/WordPress/gutenberg/issues/13000

Change History (8)

#1 @SergeyBiryukov
7 months ago

  • Component changed from General to Embeds

#2 @SergeyBiryukov
7 months ago

Thanks for the ticket!

Option to use text link instead of auto embed

Looking at https://github.com/WordPress/gutenberg/issues/15102, this should be addressed in the Gutenberg repo, there's no need for a Trac ticket for that.

Looking at https://github.com/WordPress/gutenberg/issues/13000, however, that one needs a Trac ticket.

As reported by @jeremyfelt:

When I paste https://www.nytimes.com/2018/12/18/technology/walt-mossberg-quit-facebook.html into a new post, WordPress attempts to use oEmbed to display the article, but instead just shows a partial thumbnail.

If I inspect with developer tools and remove the height: auto; that NYT delivers with the iFrame via article.story .media .image img, then I do see that other content is available, it's just not being displayed.

To reproduce

Steps to reproduce the behavior:

  1. Create a new post
  2. Paste https://www.nytimes.com/2018/12/18/technology/walt-mossberg-quit-facebook.html into the first (or any) paragraph block.

Expected behavior

To be honest, I would expect that a pasted NYT URL does not embed automatically, but I'm probably in > the minority.

The real expectation is probably that the embedded content appears in full.

Desktop

OS: OSX 10.12.6
Browser Chrome (latest)

Additional context

Using WordPress 5.0.1

...

This has changed somewhat in that the (non-WordPress) NY Times URL is detected as a WordPress embed block and results in the following code:

<!-- wp:core-embed/wordpress {"url":"https://www.nytimes.com/2018/12/18/technology/walt-mossberg-quit-facebook.html","type":"wp-embed","providerNameSlug":"the-new-york-times","className":""} -->
<figure class="wp-block-embed-wordpress wp-block-embed is-type-wp-embed is-provider-the-new-york-times"><div class="wp-block-embed__wrapper">
https://www.nytimes.com/2018/12/18/technology/walt-mossberg-quit-facebook.html
</div></figure>
<!-- /wp:core-embed/wordpress -->

The display itself still appears broken as originally reported.

@youknowriad:

I think this should probably be raised as a Core ticket instead as the embed HTML is not generated by Gutenberg itself but by the Oembed REST API.

#3 @paaljoachim
7 months ago

Related: #49173
"Allow sanitized inline styles on oEmbed iframes"

Last edited 7 months ago by SergeyBiryukov (previous) (diff)

This ticket was mentioned in Slack in #core by paaljoachim. View the logs.


7 months ago

This ticket was mentioned in Slack in #core-editor by andraganescu. View the logs.


6 months ago

This ticket was mentioned in Slack in #core by paaljoachim. View the logs.


5 months ago

#7 @paaljoachim
5 months ago

I just published a Core Editor Meeting Summary. It uses a mix of text links and one WordPress embed link.
https://make.wordpress.org/core/2020/03/13/editor-chat-summary-11-march-2020/

Why the difference between them I do not know.
It would be nice to have the option to add a WordPress embed or a text link.

This ticket was mentioned in Slack in #core-editor by paaljoachim. View the logs.


5 months ago

Note: See TracTickets for help on using tickets.