WordPress.org

Make WordPress Core

Opened 11 months ago

Closed 10 months ago

Last modified 6 months ago

#49197 closed defect (bug) (fixed)

button padding on edit plug and edit theme on mobile device

Reported by: passoniate Owned by: SergeyBiryukov
Milestone: 5.3.3 Priority: normal
Severity: normal Version: 5.3.2
Component: Editor Keywords: has-screenshots fixed-major
Focuses: ui, css Cc:

Description

button padding on edit plug and edit theme

Attachments (2)

buttonPadding.jpg (19.4 KB) - added by passoniate 11 months ago.
fix.jpg (36.4 KB) - added by passoniate 11 months ago.

Download all attachments as: .zip

Change History (12)

#1 @passoniate
11 months ago

  • Summary changed from button padding on edit plug and edit theme to button padding on edit plug and edit theme on mobile device

#2 @passoniate
11 months ago

it can be fix by this code

@media screen and (max-width: 782px)
.fileedit-sub input[type=submit] {
    margin-bottom: 0;
    padding: 0px 18px;
}

@passoniate
11 months ago

#3 @SergeyBiryukov
11 months ago

  • Milestone changed from Awaiting Review to 5.4
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

#4 @SergeyBiryukov
11 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 47071:

File Editor: Remove extra padding on submit button for "Select plugin/theme to edit" dropdown on smaller screens.

Props passoniate.
Fixes #49197.

#5 follow-up: @audrasjb
11 months ago

@SergeyBiryukov In my opinion, this one could be a nice candidate for an eventual point release as for me it's a regression from 5.3.x, isn't it?

#6 in reply to: ↑ 5 @SergeyBiryukov
11 months ago

  • Keywords fixed-major added
  • Milestone changed from 5.4 to 5.3.3
  • Resolution fixed deleted
  • Status changed from closed to reopened

Replying to audrasjb:

In my opinion, this one could be a nice candidate for an eventual point release as for me it's a regression from 5.3.x, isn't it?

Apparently it is, thanks :) Reopening for 5.3.3 consideration.

#7 @SergeyBiryukov
10 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 47128:

File Editor: Remove extra padding on submit button for "Select plugin/theme to edit" dropdown on smaller screens.

Props passoniate.
Merges [47071] to the 5.3 branch.
Fixes #49197.

#8 @afercia
7 months ago

Looking at [47128], CSS 0 values should be unitless. Will fix in #49353 and reopen it for 5.3.3 consideration (ahem... WP trunk is 5.5 now).

Last edited 7 months ago by afercia (previous) (diff)

#9 @afercia
7 months ago

In 47751:

File Editor: Remove CSS exceptions for the "Select plugin/theme to edit" and documentation "Look Up" buttons.

Buttons should use the default buttons styles, no exceptions.

Props passoniate, garethgillman.
See #49197.
Fixes #49353.

#10 @whyisjake
6 months ago

In 47824:

File Editor: Remove CSS exceptions for the "Select plugin/theme to edit" and documentation "Look Up" buttons.
Buttons should use the default buttons styles, no exceptions.

This commit bring the changes from [47751] to the 5.4 branch.

Props passoniate, garethgillman, @afercia.
See #49197.
Fixes #49353.

Note: See TracTickets for help on using tickets.