WordPress.org

Make WordPress Core

Opened 4 months ago

Closed 4 months ago

#49211 closed enhancement (fixed)

Menus: make tabs panels more accessible for keyboard users

Reported by: audrasjb Owned by: audrasjb
Milestone: 5.4 Priority: normal
Severity: normal Version:
Component: Menus Keywords: has-patch has-screenshots commit
Focuses: ui, accessibility, css Cc:

Description

In #48655, the discussion moved from a better handling of Add menu item action in Menus screen to further accessibility enhancements (like using aria labels, regions, and so on).

As @azaozz pointed out in the WP 5.3 post-mortem, we should rather use a dedicated ticket as the proposed enhancement doesn't cover the bug intially raised by the ticket reporter.

Let's improve navigation for keyboard users in Menus screen in this specific ticket.

To summarize, we need to improve the keyboard navigation in Add menu item sections tab panels.

@afercia proposed to follow the recommendations available on this post: https://developer.paciellogroup.com/blog/2016/02/short-note-on-improving-usability-of-scrollable-regions/

Attachments (3)

49211.diff (4.4 KB) - added by audrasjb 4 months ago.
Menus: make tabs panels more accessible for keyboard users
49211.1.diff (4.8 KB) - added by audrasjb 4 months ago.
Add box-shadow on panel container only on focus, for better keyboard navigation
6803bf8c656fd7d4b8c4f224ac8706f1.gif (1.2 MB) - added by audrasjb 4 months ago.
Add box-shadow on panel container only on focus, for better keyboard navigation

Download all attachments as: .zip

Change History (9)

@audrasjb
4 months ago

Menus: make tabs panels more accessible for keyboard users

@audrasjb
4 months ago

Add box-shadow on panel container only on focus, for better keyboard navigation

@audrasjb
4 months ago

Add box-shadow on panel container only on focus, for better keyboard navigation

#2 @audrasjb
4 months ago

  • Keywords has-patch has-screenshots added; needs-patch removed

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


4 months ago

#4 @afercia
4 months ago

  • Keywords commit added

This ticket was discussed during today's accessibility bug-scrub. Ideally, this UI should be an ARIA tabbed interface so that the role=region would be a more appropriate role=tabpanel. This is a separate issue though that can be iterated later.

Marking for commit for final review.

#5 @SergeyBiryukov
4 months ago

I think it would make sense to use existing post type and taxonomy labels here:

  • Most Recent → stays as is, doesn't have a direct match.
  • Search Results$post_type->labels->search_items
  • All Items$post_type->labels->all_items
  • Most Used$taxonomy->labels->most_used
  • All Items$taxonomy->labels->all_items
  • Search Results$taxonomy->labels->search_items

Looks good to me otherwise :)

Last edited 4 months ago by SergeyBiryukov (previous) (diff)

#6 @SergeyBiryukov
4 months ago

  • Resolution set to fixed
  • Status changed from assigned to closed

In 47209:

Accessibility: Menus: Make tab panels in Add menu items section more accessible for keyboard users.

Props audrasjb, afercia.
Fixes #49211.

Note: See TracTickets for help on using tickets.