WordPress.org

Make WordPress Core

Opened 6 weeks ago

Last modified 8 days ago

#49228 accepted defect (bug)

Widgets: Checkbox overlap on small screens

Reported by: passoniate Owned by: audrasjb
Milestone: 5.5 Priority: normal
Severity: normal Version: 5.3.2
Component: Widgets Keywords: has-screenshots good-first-bug has-patch needs-testing
Focuses: ui, accessibility Cc:

Description

Checkbox overlap need to margin-top

Attachments (4)

checkboxoverlap.png (22.5 KB) - added by passoniate 6 weeks ago.
On mobile device
Capture d’écran 2020-01-19 à 14.45.58.png (23.7 KB) - added by audrasjb 6 weeks ago.
49228.diff (391 bytes) - added by milindmore22 5 weeks ago.
Fixes overlapping checkboxes and radio buttons on Chrome Safari and Firefox Browsers on Responsive Screen
wp 5.1.png (84.6 KB) - added by afercia 3 weeks ago.

Download all attachments as: .zip

Change History (17)

@passoniate
6 weeks ago

On mobile device

#1 @audrasjb
6 weeks ago

  • Keywords reporter-feedback added

Hi, thanks for opening this ticket,

Could you please give some context for this issue?
Would be nice to describe the issue and where it happens (which admin screen, etc.) and on which browser.
It would also be very helpful to provide screenshots for the issue :-)

Cheers,
Jb

#2 @audrasjb
6 weeks ago

  • Keywords needs-patch added; reporter-feedback removed
  • Milestone changed from Awaiting Review to 5.3.3
  • Status changed from assigned to accepted

Thanks @passoniate I can reproduce the issue on my side.
Let's handle that in the next minor as it's a regression from 5.3.

#3 @audrasjb
6 weeks ago

  • Summary changed from Checkbox overlap to Widgets: Checkbox overlap on small screens

#4 @audrasjb
6 weeks ago

This issue occurs only on Categories and Archives widgets.
I think the easier solution is to use proper paragraph wrapper for each input line.

#5 @audrasjb
6 weeks ago

  • Keywords good-first-bug added

#6 @audrasjb
6 weeks ago

Adding good-first-bug keyword, which means that experimented contributors (= people that already contributed to a core patch) should ideally leave few days for first timers to give it a try before adding a patch.

@milindmore22
5 weeks ago

Fixes overlapping checkboxes and radio buttons on Chrome Safari and Firefox Browsers on Responsive Screen

#7 @milindmore22
5 weeks ago

  • Keywords has-patch added; needs-patch removed

#8 @audrasjb
4 weeks ago

  • Milestone changed from 5.3.3 to 5.4

Moving all unfixed tickets from 5.3.3 to milestone 5.4, as there is no plan for a 5.3.3 maintenance release for now.

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


3 weeks ago

#10 @afercia
3 weeks ago

This ticket was discussed during today's accessibility bug-scrub. Noticed the checkboxes slightly overlap now on 5.3. On all previous versions a vertical spacing was missing as well, even if there was no overlap. See attached screenshot from WP 5.1.

@afercia
3 weeks ago

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


2 weeks ago

#12 @afercia
2 weeks ago

  • Keywords needs-testing added

This ticket was discussed during today's accessibility bug-scrub: the proposed patch appears to target all checkboxes and radio buttons on small screens. Needs to be reviewed carefully as this will change the margins for all these elements within paragraphs.

#13 @audrasjb
8 days ago

  • Milestone changed from 5.4 to 5.5

Hi,

Given the last comment and with 5.4 Beta 3 approaching and the Beta period reserved for bugs introduced during the cycle, this is being moved to WP 5.5.

Note: See TracTickets for help on using tickets.