WordPress.org

Make WordPress Core

Opened 5 weeks ago

Last modified 25 hours ago

#49231 accepted defect (bug)

Plugins admin screens: form fields issue on small screens

Reported by: passoniate Owned by: audrasjb
Milestone: 5.4 Priority: normal
Severity: normal Version: 5.3.2
Component: Plugins Keywords: has-patch
Focuses: ui, accessibility, css Cc:

Description

Plugins admin screens: form fields issue on small screens

Attachments (9)

addplugin.png (19.0 KB) - added by passoniate 5 weeks ago.
alignmnet.png (25.6 KB) - added by passoniate 5 weeks ago.
common.css.patch (425 bytes) - added by garethgillman 2 weeks ago.
Adds margin to the select box when under 600px width
common.min.css.patch (34.9 KB) - added by passoniate 12 days ago.
Patch for RTL and LTR
list-tables.css.patch (129.0 KB) - added by passoniate 12 days ago.
Patch for RTL and LTR
common.css.2.patch (433 bytes) - added by passoniate 11 days ago.
common.css Patch Update
list-tables.css.2.patch (547 bytes) - added by passoniate 11 days ago.
list-tables.css Patch Update
49231.600.patch (881 bytes) - added by sabernhardt 26 hours ago.
Sets search box top margin at 600px breakpoint and edits padding for select all checkbox
49231.782.patch (885 bytes) - added by sabernhardt 26 hours ago.
Sets search box top margin at 782px breakpoint and edits padding for select all checkbox

Download all attachments as: .zip

Change History (21)

@passoniate
5 weeks ago

@passoniate
5 weeks ago

#1 @audrasjb
5 weeks ago

  • Focuses css added
  • Milestone changed from Awaiting Review to 5.3.3
  • Status changed from assigned to accepted

#2 @audrasjb
5 weeks ago

  • Keywords needs-patch added

Good catch. For the second issue, we should probably use:

@media screen and (max-width: 782px) {
    #wpbody-content .wp-list-table.plugins td
        padding: 10px 6px;
    }
}

Instead of

@media screen and (max-width: 782px) {
    #wpbody-content .wp-list-table.plugins td
        padding: 10px 9px;
    }
}

#3 @audrasjb
5 weeks ago

The first issue doesn't looks like a blocker to me. We may want to improve it if possible though.

#4 @audrasjb
3 weeks ago

  • Milestone changed from 5.3.3 to 5.4

Moving all unfixed tickets from 5.3.3 to milestone 5.4, as there is no plan for a 5.3.3 maintenance release for now.

@garethgillman
2 weeks ago

Adds margin to the select box when under 600px width

#5 @audrasjb
13 days ago

Would be great to get a patch for both issues.

@passoniate
12 days ago

Patch for RTL and LTR

@passoniate
12 days ago

Patch for RTL and LTR

#6 @passoniate
12 days ago

  • Keywords has-patch needs-testing added; has-screenshots needs-patch removed

#7 @audrasjb
11 days ago

  • Keywords needs-refresh added

Hi! Thank you for the patch!
RTL and minified versions of the file are generated automatically and don't need to be patched.

@passoniate
11 days ago

common.css Patch Update

@passoniate
11 days ago

list-tables.css Patch Update

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


8 days ago

#9 @afercia
8 days ago

This ticket was discussed during today's accessibility bug-scrub: it would be great to unify the various patches in just one for easier review and commit :)

#10 @audrasjb
38 hours ago

  • Keywords commit added; needs-testing needs-refresh removed

Works fine on my side.
Marking this for commit.
Please note it should be committed as soon as possible or punted to 5.5 if we are not able to commit very soon :-)

#11 @sabernhardt
26 hours ago

  • Keywords commit removed

@passoniate Thanks! The latest change to list-table.css looks good, but the search box's top margin is set twice in the common.css.2.patch.

Which top margin should we keep? I do not see a need for it at the 782px breakpoint. However, if I'm missing something and that should be at 782, then it's redundant to add the margin again at the 600px breakpoint.

I'll upload combined patches to review both options.

@sabernhardt
26 hours ago

Sets search box top margin at 600px breakpoint and edits padding for select all checkbox

@sabernhardt
26 hours ago

Sets search box top margin at 782px breakpoint and edits padding for select all checkbox

This ticket was mentioned in Slack in #accessibility by afercia. View the logs.


25 hours ago

Note: See TracTickets for help on using tickets.