WordPress.org

Make WordPress Core

Opened 8 months ago

Closed 8 months ago

#49235 closed defect (bug) (fixed)

Sentence correction in wp-admin/options-general.php file

Reported by: kinjaldalwadi Owned by: SergeyBiryukov
Milestone: 5.4 Priority: normal
Severity: normal Version: 5.4
Component: Administration Keywords: has-patch 2nd-opinion
Focuses: ui-copy Cc:

Description

Need to make correction in below sentence by adding "then":
Sentence : If you change this we will send you an email at your new address to confirm it.
Need correction : If you change this then we will send you an email at your new address to confirm it.

Screenshot : https://prnt.sc/qpvkqu

Attachments (4)

47087.patch (1.2 KB) - added by kinjaldalwadi 8 months ago.
wp-admin/options-general.php file
47104.patch (668 bytes) - added by kinjaldalwadi 8 months ago.
wp-admin/user-edit.php file
47104.2.patch (960 bytes) - added by kinjaldalwadi 8 months ago.
wp-admin/network/settings.php file
49235.4.diff (2.9 KB) - added by donmhico 8 months ago.

Download all attachments as: .zip

Change History (9)

@kinjaldalwadi
8 months ago

wp-admin/options-general.php file

#1 @SergeyBiryukov
8 months ago

  • Component changed from General to Administration
  • Focuses ui-copy added
  • Keywords has-patch 2nd-opinion added; Sentence correction settings options-general.php removed

Hi there, welcome to WordPress Trac! Thanks for the ticket and the patch.

This sentence looks correct to me as is, though perhaps would be better with a comma.

Adding ui-copy focus to get some more eyes on it.

#2 @SergeyBiryukov
8 months ago

#49267 was marked as a duplicate.

#3 @SergeyBiryukov
8 months ago

  • Milestone changed from Awaiting Review to 5.4
  • Owner set to SergeyBiryukov
  • Status changed from new to reviewing

@kinjaldalwadi
8 months ago

wp-admin/user-edit.php file

@kinjaldalwadi
8 months ago

wp-admin/network/settings.php file

@donmhico
8 months ago

#4 @donmhico
8 months ago

Thanks for the patch @kinjaldalwadi. I combined all of the patches in a single patch 49235.4.diff.

#5 @SergeyBiryukov
8 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 47143:

Administration: Add punctuation to "If you change this, we will send you an email" message on General Settings, Network Settings, and Profile screens.

Props kinjaldalwadi, donmhico.
Fixes #49235.

Note: See TracTickets for help on using tickets.