WordPress.org

Make WordPress Core

Opened 6 weeks ago

Last modified 4 days ago

#49236 new enhancement

Use 'comment' instead of '' for the comment_type db field for comments

Reported by: imath Owned by:
Milestone: 5.5 Priority: normal
Severity: normal Version: trunk
Component: Comments Keywords: has-patch needs-refresh
Focuses: Cc:

Description

Following @aaroncampbell and @jeremyfelt suggestions on #35214 this ticket is a first step to bring custom comment types into WordPress. This first step's goal is to start using comment for the comment_type field value of the wp_comments table.

To build the patch I've tried to make sure all functions/requests now use 'comment' instead of ''. I've tested the upgrade routine with some comments.

I haven't set the milestone as I'm unsure if this is something that is doable before 5.4-beta1. I imagine the upgrade routine might need some testing on websites having a lot of comments.

Attachments (1)

49236.patch (7.5 KB) - added by imath 6 weeks ago.

Download all attachments as: .zip

Change History (5)

@imath
6 weeks ago

#1 @dshanske
6 weeks ago

You might want to have a look at the batch processing of terms introduced in #30261 for a way to split conversion into smaller jobs run by cron.

#2 @imath
5 weeks ago

Hi @dshanske

Thanks a lot for pointing me to the split terms upgrade ticket. I will look into it once 5.4.0 is released, which means I think it's safer to move this 5.5.0 once this milestone will be created.

This ticket was mentioned in Slack in #core by imath. View the logs.


4 weeks ago

#4 @imath
4 days ago

  • Keywords needs-refresh added
  • Milestone changed from Awaiting Review to 5.5
Note: See TracTickets for help on using tickets.